Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context.

test/cctest/test-strings.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 23 matching lines @@
 
 #include "v8.h"
 
 #include "api.h"
 #include "factory.h"
 #include "objects.h"
 #include "cctest.h"
 #include "zone-inl.h"
 
 // Adapted from http://en.wikipedia.org/wiki/Multiply-with-carry
-class RandomNumberGenerator {
+class MyRandomNumberGenerator {
  public:
-  RandomNumberGenerator() {
+  MyRandomNumberGenerator() {
     init();
   }
 
   void init(uint32_t seed = 0x5688c73e) {
     static const uint32_t phi = 0x9e3779b9;
     c = 362436;
     i = kQSize-1;
     Q[0] = seed;
     Q[1] = seed + phi;
     Q[2] = seed + phi + phi;
@@ skipping 69 matching lines @@
 
  private:
   const char* data_;
   size_t length_;
 };
 
 
 static void InitializeBuildingBlocks(Handle<String>* building_blocks,
                                      int bb_length,
                                      bool long_blocks,
-                                     RandomNumberGenerator* rng,
+                                     MyRandomNumberGenerator* rng,
                                      Zone* zone) {
   // A list of pointers that we don't have any interest in cleaning up.
   // If they are reachable from a root then leak detection won't complain.
   Isolate* isolate = Isolate::Current();
   Factory* factory = isolate->factory();
   for (int i = 0; i < bb_length; i++) {
     int len = rng->next(16);
     int slice_head_chars = 0;
     int slice_tail_chars = 0;
     int slice_depth = 0;
@@ skipping 122 matching lines @@
   inline Handle<String> block(uint32_t offset);
   // Input variables.
   double early_termination_threshold_;
   double leftness_;
   double rightness_;
   double empty_leaf_threshold_;
   unsigned max_leaves_;
   // Cached data.
   Handle<String> building_blocks_[kNumberOfBuildingBlocks];
   String* empty_string_;
-  RandomNumberGenerator rng_;
+  MyRandomNumberGenerator rng_;
   // Stats.
   ConsStringStats stats_;
   unsigned early_terminations_;
  private:
   DISALLOW_COPY_AND_ASSIGN(ConsStringGenerationData);
 };
 
 
 ConsStringGenerationData::ConsStringGenerationData(bool long_blocks,
                                                    Zone* zone) {
@@ skipping 1089 matching lines @@
       CheckCanonicalEquivalence(c, test);
       continue;
     }
     if (upper != c && lower != c) {
       CheckCanonicalEquivalence(c, test);
       continue;
     }
     CHECK_EQ(Min(upper, lower), test);
   }
 }