Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 23548017: border-spacing is doubled between table-row-groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/table-sections-border-spacing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTableSection.cpp
diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp
index fa33fb705d89d556526178dc2e118d9bad763dbd..da4b53a56e5c1fb5c6908e7bd47bd46eca864cab 100644
--- a/Source/core/rendering/RenderTableSection.cpp
+++ b/Source/core/rendering/RenderTableSection.cpp
@@ -520,7 +520,12 @@ int RenderTableSection::calcRowLogicalHeight()
LayoutStateMaintainer statePusher(viewRenderer);
m_rowPos.resize(m_grid.size() + 1);
- m_rowPos[0] = table()->vBorderSpacing();
+
+ // We ignore the border-spacing on any non-top section as it is already included in the previous section's last row position.
+ if (this == table()->topSection())
+ m_rowPos[0] = table()->vBorderSpacing();
+ else
+ m_rowPos[0] = 0;
SpanningRenderTableCells rowSpanCells;
« no previous file with comments | « LayoutTests/fast/table/table-sections-border-spacing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698