Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: LayoutTests/fast/table/table-sections-border-spacing.html

Issue 23548017: border-spacing is doubled between table-row-groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-sections-border-spacing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/table/table-sections-border-spacing.html
diff --git a/LayoutTests/fast/table/table-sections-border-spacing.html b/LayoutTests/fast/table/table-sections-border-spacing.html
new file mode 100644
index 0000000000000000000000000000000000000000..7c9fa70a5d3d486258cdec808f809121b62d713a
--- /dev/null
+++ b/LayoutTests/fast/table/table-sections-border-spacing.html
@@ -0,0 +1,67 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src="../js/resources/js-test-pre.js"></script>
+</head>
+<body>
+<h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=29502">29502</a>. border-spacing is doubled between table-row-groups.</h3>
+<h4>Border-spacing was adding twice, One for bottom of first section and another for top of second section. But bottom of first section and top of second section border spacing should be common.</h4>
+Distance between all rows in the table should be same.
+<br/><br/>
+
+<div id="divId">
+<table border="5" style="border-spacing:10px">
+ <thead>
+ <tr>
+ <th id = "td0Id"> row0 head0 </th>
+ <th> row0 head1 </th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td id = "td1Id"> row0 col0 </td>
+ <td> row0 col11 </td>
+ </tr>
+ <tr>
+ <td id = "td2Id"> row1 col0 </td>
+ <td> row1 col11 </td>
+ </tr>
+ </tbody>
+ <tbody>
+ <tr>
+ <td id = "td3Id"> row0 col0 </td>
+ <td> row0 col11 </td>
+ </tr>
+ <tr>
+ <td id = "td4Id"> row1 col0 </td>
+ <td> row1 col11 </td>
+ </tr>
+ </tbody>
+ <tfoot>
+ <tr>
+ <td id = "td5Id"> row0 foot0 </td>
+ <td> row0 foot1 </td>
+ </tr>
+ </tfoot>
+</table>
+</div>
+<br/>
+<div id="console"></div>
+
+<script>
+ function testBorderSpacing(index)
+ {
+ var afterRow = document.getElementById('td' + index + 'Id');
+ var beforeRow = document.getElementById('td' + (index - 1) + 'Id');
+ var borderSpacing = afterRow.offsetTop - beforeRow.offsetTop - beforeRow.offsetHeight;
+ shouldBe(borderSpacing.toString(), "10");
+ }
+
+ for (var i = 1; i < 6; i++) {
+ document.getElementById('console').appendChild(document.createElement('br'));
+ testBorderSpacing(i);
+ }
+</script>
+
+</body>
+</html>
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-sections-border-spacing-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698