Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 23548017: border-spacing is doubled between table-row-groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTableSection.cpp
diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp
index de1f54512902e387a152a99808b85479511d81cf..0a2a942edf88f789f24e42774ea876f043f662ad 100644
--- a/Source/core/rendering/RenderTableSection.cpp
+++ b/Source/core/rendering/RenderTableSection.cpp
@@ -511,7 +511,13 @@ int RenderTableSection::calcRowLogicalHeight()
LayoutStateMaintainer statePusher(viewRenderer);
m_rowPos.resize(m_grid.size() + 1);
- m_rowPos[0] = table()->vBorderSpacing();
+
+ // Top border spacing of the section is required to add only for the first section in the table.
+ // Because top border spacing of following sections would be bottom border spacing of it's previous section.
Julien - ping for review 2013/09/05 17:58:03 Good comment, let's improve it: // We ignore the
a.suchit 2013/09/06 05:27:18 Done.
+ if (this == table()->topSection())
+ m_rowPos[0] = table()->vBorderSpacing();
+ else
+ m_rowPos[0] = 0;
SpanningRenderTableCells rowSpanCells;

Powered by Google App Engine
This is Rietveld 408576698