LayoutTests/fast/table/table-sections-border-spacing.html - Issue 23548017: border-spacing is doubled between table-row-groups.

Side by Side Diff: LayoutTests/fast/table/table-sections-border-spacing.html

Issue 23548017: border-spacing is doubled between table-row-groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../js/resources/js-test-pre.js"></script>

	5 </head>

	6 <body>

	7 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=29502">29502</a>. border-spacing is doubled between table-row-groups.</ h3>

	8 <h4>Border-spacing was adding twice, One for bottom of first section and another for top of second section. But bottom of first section and top of second sectio n border spacing should be common.</h4>

	9 Distance between all rows in the table should be same.

	10 <br/><br/>

	11

	12 <div id="divId">

	13 <table border="5" style="border-spacing:10px">

	14 <thead>

	15 <tr>

	16 <th id = "thId"> row0 head0 </th>

	17 <th> row0 head1 </th>

	18 </tr>

	19 </thead>

	20 <tbody>

	21 <tr>

	22 <td id = "td1Id"> row0 col0 </td>

	23 <td> row0 col11 </td>

	24 </tr>

	25 <tr>

	26 <td id = "td2Id"> row1 col0 </td>

	27 <td> row1 col11 </td>

	28 </tr>

	29 </tbody>

	30 <tbody>

	31 <tr>

	32 <td id = "td3Id"> row0 col0 </td>

	33 <td> row0 col11 </td>

	34 </tr>

	35 <tr>

	36 <td id = "td4Id"> row1 col0 </td>

	37 <td> row1 col11 </td>

	38 </tr>

	39 </tbody>

	40 <tfoot>

	41 <tr>

	42 <td id = "td5Id"> row0 foot0 </td>

	43 <td> row0 foot1 </td>

	44 </tr>

	45 </tfoot>

	46 </table>

	47 </div>

	48 <br/>

	49 <div id="console"></div>

	50

	51 <script>

	52 document.getElementById('console').appendChild(document.createElement('br')) ;
	Julien - ping for review 2013/09/05 17:58:03 Looks like you need a function as this line is rep Looks like you need a function as this line is repeated 6 times. a.suchit 2013/09/06 05:27:18 Done. Show quoted text On 2013/09/05 17:58:03, Julien Chaffraix wrote: > Looks like you need a function as this line is repeated 6 times. Done.
	53 shouldBe("(document.getElementById('td1Id').offsetTop - document.getElementB yId('thId').offsetTop - document.getElementById('thId').offsetHeight)", "10");
	Julien - ping for review 2013/09/05 17:58:03 The logic is similar, maybe we could just renamed The logic is similar, maybe we could just renamed the first 'thId' to 'td0Id' and just have a test for the values 0..4 with a helper function: function testBorderSpacing(index) { var afterRow = document.getElementById('td' + index + 'Id'); var beforeRow = document.getElementById('td' + index - 1 + 'Id'); var borderSpacing = afterRow.offsetTop - beforeRow.offsetTop - beforeRow.offsetHeight; shouldBe(borderSpacing, 10); } a.suchit 2013/09/06 05:27:18 Done. Show quoted text On 2013/09/05 17:58:03, Julien Chaffraix wrote: > The logic is similar, maybe we could just renamed the first 'thId' to 'td0Id' > and just have a test for the values 0..4 with a helper function: > > function testBorderSpacing(index) > { > var afterRow = document.getElementById('td' + index + 'Id'); > var beforeRow = document.getElementById('td' + index - 1 + 'Id'); > var borderSpacing = afterRow.offsetTop - beforeRow.offsetTop - > beforeRow.offsetHeight; > shouldBe(borderSpacing, 10); > } Done.
	54 document.getElementById('console').appendChild(document.createElement('br')) ;

	55 shouldBe("(document.getElementById('td2Id').offsetTop - document.getElementB yId('td1Id').offsetTop - document.getElementById('td1Id').offsetHeight)", "10");

	56 document.getElementById('console').appendChild(document.createElement('br')) ;

	57 shouldBe("(document.getElementById('td3Id').offsetTop - document.getElementB yId('td2Id').offsetTop - document.getElementById('td2Id').offsetHeight)", "10");

	58 document.getElementById('console').appendChild(document.createElement('br')) ;

	59 shouldBe("(document.getElementById('td4Id').offsetTop - document.getElementB yId('td3Id').offsetTop - document.getElementById('td3Id').offsetHeight)", "10");

	60 document.getElementById('console').appendChild(document.createElement('br')) ;

	61 shouldBe("(document.getElementById('td5Id').offsetTop - document.getElementB yId('td4Id').offsetTop - document.getElementById('td4Id').offsetHeight)", "10");

	62 </script>

	63

	64 </body>

	65 </html>

OLD	NEW