Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 23548010: Have htmlediting create functions take a Document reference in argument (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Have htmlediting create functions take a Document reference in argument Have htmlediting create functions take a Document reference in argument instead of a pointer since they require the document to be non-null. Most of the callers already have a Document reference so this change avoids having to convert references into pointers at call sites. This patch is a prequirement to have HTMLElements take a Document reference in argument. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -100 lines) Patch
M Source/core/editing/ApplyBlockElementCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ModifySelectionListLevel.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 3 chunks +23 lines, -23 lines 0 comments Download
M Source/core/editing/markup.cpp View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-02 17:21:47 UTC) #1
do-not-use
7 years, 3 months ago (2013-09-02 19:54:41 UTC) #2
dglazkov
rslgtm. Y BOTS red?
7 years, 3 months ago (2013-09-02 20:14:33 UTC) #3
do-not-use
On 2013/09/02 20:14:33, Dimitri Glazkov wrote: > rslgtm. Y BOTS red? I believe those are ...
7 years, 3 months ago (2013-09-02 20:19:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23548010/1
7 years, 3 months ago (2013-09-02 20:20:11 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 21:41:21 UTC) #6
Message was sent while issue was closed.
Change committed as 157092

Powered by Google App Engine
This is Rietveld 408576698