content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 23548008: Don't set the request target type to object when navigating from a Pepper plug-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 23548008: Don't set the request target type to object when navigating from a Pepper plug-in. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index 49daf81eb43eb74139bcd78eb44888b8ff8fce0c..fd57f0896db531a7193cdecc7813417a7254bb60 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -2756,7 +2756,10 @@ int32_t PepperPluginInstanceImpl::Navigate(

ppapi::URLRequestInfoData completed_request = request;

WebURLRequest web_request;

- if (!CreateWebURLRequest(&completed_request, frame, &web_request))

+ if (!CreateWebURLRequest(&completed_request,

+ WebURLRequest::TargetIsMainFrame,

yzshen1 2013/09/03 18:13:40 Is it possible that this navigate happens in a sub

Bernhard Bauer 2013/09/03 20:58:02 Hm, good point! Fixed.

+ frame,

+ &web_request))

return PP_ERROR_FAILED;

web_request.setFirstPartyForCookies(document.firstPartyForCookies());

web_request.setHasUserGesture(from_user_action);

« no previous file with comments | « no previous file | content/renderer/pepper/pepper_url_loader_host.cc » ('j') | no next file with comments »