Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23548006: Remove IME related configuration preferences in Chrome OS. (Closed)

Created:
7 years, 3 months ago by Hiro Komatsu
Modified:
7 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove IME related configuration preferences in Chrome OS. Since the IMEs has been migrated from native application to extensions. There entries are no longer necessary. BUG=256102 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221995

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comments based on the review. #

Patch Set 3 : Delete unused JS code. #

Patch Set 4 : Remove unnecessary comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2012 lines) Patch
M chrome/browser/chromeos/language_preferences.h View 1 3 chunks +3 lines, -131 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.cc View 2 chunks +0 lines, -373 lines 0 comments Download
D chrome/browser/chromeos/language_preferences_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +0 lines, -106 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_chewing_options.html View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_hangul_options.html View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_mozc_options.html View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_pinyin_options.html View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 2 3 4 chunks +0 lines, -45 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_chewing_handler.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_chewing_handler.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_mozc_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_mozc_handler.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_options_util.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_options_util.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hiro Komatsu
7 years, 3 months ago (2013-09-02 06:03:07 UTC) #1
Seigo Nonaka
lgtm lgtm with nits https://codereview.chromium.org/23548006/diff/1/chrome/browser/chromeos/language_preferences.h File chrome/browser/chromeos/language_preferences.h (right): https://codereview.chromium.org/23548006/diff/1/chrome/browser/chromeos/language_preferences.h#newcode20 chrome/browser/chromeos/language_preferences.h:20: // For ibus-daemon Please update ...
7 years, 3 months ago (2013-09-02 06:14:33 UTC) #2
Hiro Komatsu
Hi James, Satoru, Could you give your LGTMs? This patch just deletes unused files. Thank ...
7 years, 3 months ago (2013-09-02 06:37:12 UTC) #3
satorux1
LGTM. Huge code reduction!
7 years, 3 months ago (2013-09-03 05:36:51 UTC) #4
James Hawkins
lgtm
7 years, 3 months ago (2013-09-03 17:02:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23548006/26001
7 years, 3 months ago (2013-09-09 04:26:03 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 10:01:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 221995

Powered by Google App Engine
This is Rietveld 408576698