Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: content/browser/renderer_host/text_input_manager.h

Issue 2354793003: Browser Side TextInputState Tracking for Android (Closed)
Patch Set: Addressing kenrb@'s comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/text_input_manager.h
diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h
index 4bf2da6b7c2c23e87aa32460aec065c4270ed168..be779a724f7439121fbf76ce3fda98799581ffc1 100644
--- a/content/browser/renderer_host/text_input_manager.h
+++ b/content/browser/renderer_host/text_input_manager.h
@@ -124,9 +124,12 @@ class CONTENT_EXPORT TextInputManager {
// Users of these methods should not hold on to the pointers as they become
// dangling if the TextInputManager or |active_view_| are destroyed.
- // Returns the currently stored TextInputState. An state of nullptr can be
- // interpreted as a ui::TextInputType of ui::TEXT_INPUT_TYPE_NONE.
- const TextInputState* GetTextInputState() const;
+ // Returns the currently stored TextInputState for |view|. An state of nullptr
Charlie Reis 2016/11/02 22:23:13 nit: A state
EhsanK 2016/11/18 19:55:59 Done.
+ // can be interpreted as a ui::TextInputType of ui::TEXT_INPUT_TYPE_NONE for
+ // the view. If |view| is null, and there is an |active_view_|, the state for
Charlie Reis 2016/11/02 22:23:13 nit: No comma after null
EhsanK 2016/11/18 19:55:59 Acknowledged.
+ // |active_view_| is returned.
+ const TextInputState* GetTextInputState(
+ RenderWidgetHostViewBase* view = nullptr) const;
// Returns the selection bounds information for |view|. If |view| == nullptr,
// it will return the corresponding information for |active_view_| or nullptr

Powered by Google App Engine
This is Rietveld 408576698