Browser Side TextInputState Tracking for Android

content/browser/renderer_host/text_input_manager.cc

Index: content/browser/renderer_host/text_input_manager.cc
diff --git a/content/browser/renderer_host/text_input_manager.cc b/content/browser/renderer_host/text_input_manager.cc
index 3b75d36aca95cf2e63c1f29109057b2f2b796ec4..868d9cd6c9a4d3fd2e85eecac40b5525f0db778b 100644
--- a/content/browser/renderer_host/text_input_manager.cc
+++ b/content/browser/renderer_host/text_input_manager.cc
@@ -25,8 +25,8 @@ bool AreDifferentTextInputStates(const content::TextInputState& old_state,
   return old_state.type != new_state.type ||
          old_state.can_compose_inline != new_state.can_compose_inline;
 #else
-  // TODO(ekaramad): Implement the logic for other platforms (crbug.com/578168).
-  NOTREACHED();
+  // On Android, TextInputState update is sent only if there is some change in
+  // the state. So the new state is always different.

[Charlie Reis, 2016/11/02 22:23:13]

nit: Comma, not period.  (Second sentence is not a sentence.)

Still, this behavior seems a bit unexpected.  Wouldn't this be confusing if
future code added a call to AreDifferentTextInputStates and it returns true for
two identical states?

[EhsanK, 2016/11/18 19:55:59]

Acknowledged...and good point. I believe what needs to be changed is the method
name. We only use this to determine if TextInputState should be updated (given
the old and new state).

   return true;
 #endif
 }
@@ -57,8 +57,12 @@ RenderWidgetHostImpl* TextInputManager::GetActiveWidget() const {
                         : nullptr;
 }
 
-const TextInputState* TextInputManager::GetTextInputState() const {
-  return !!active_view_ ? &text_input_state_map_.at(active_view_) : nullptr;
+const TextInputState* TextInputManager::GetTextInputState(
+    RenderWidgetHostViewBase* view) const {
+  DCHECK(!view || IsRegistered(view));
+  if (!view)
+    view = active_view_;
+  return !!view ? &text_input_state_map_.at(view) : nullptr;
 }
 
 const TextInputManager::SelectionRegion* TextInputManager::GetSelectionRegion(