Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2354793003: Browser Side TextInputState Tracking for Android (Closed)
Patch Set: Rebased + Removed unused Forward Dec Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 08ef4aede304e26ffaeedd96606a706c3ec47796..d4cb855812f08570820d00e7182446526b9b3660 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -468,6 +468,9 @@ RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
host_->SetView(this);
SetContentViewCore(content_view_core);
+
+ if (GetTextInputManager())
+ GetTextInputManager()->AddObserver(this);
}
RenderWidgetHostViewAndroid::~RenderWidgetHostViewAndroid() {
@@ -757,22 +760,29 @@ long RenderWidgetHostViewAndroid::GetNativeImeAdapter() {
return reinterpret_cast<intptr_t>(&ime_adapter_android_);
}
-void RenderWidgetHostViewAndroid::TextInputStateChanged(
- const TextInputState& params) {
- if (params.is_non_ime_change) {
+// -----------------------------------------------------------------------------
+// TextInputManager::Observer implementations.
+void RenderWidgetHostViewAndroid::OnUpdateTextInputStateCalled(
+ TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view,
+ bool did_change_state) {
+ DCHECK_EQ(text_input_manager_, text_input_manager);
+ const TextInputState& state =
+ *GetTextInputManager()->GetTextInputState(updated_view);
+ if (state.is_non_ime_change && updated_view->GetRenderWidgetHost()) {
// Sends an acknowledgement to the renderer of a processed IME event.
- host_->Send(new InputMsg_ImeEventAck(host_->GetRoutingID()));
+ updated_view->GetRenderWidgetHost()->Send(
+ new InputMsg_ImeEventAck(host_->GetRoutingID()));
}
if (!content_view_core_)
return;
content_view_core_->UpdateImeAdapter(
- GetNativeImeAdapter(),
- static_cast<int>(params.type), params.flags,
- params.value, params.selection_start, params.selection_end,
- params.composition_start, params.composition_end,
- params.show_ime_if_needed, params.is_non_ime_change);
+ GetNativeImeAdapter(), static_cast<int>(state.type), state.flags,
+ state.value, state.selection_start, state.selection_end,
+ state.composition_start, state.composition_end, state.show_ime_if_needed,
+ state.is_non_ime_change);
}
void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {
@@ -926,6 +936,9 @@ void RenderWidgetHostViewAndroid::Destroy() {
// The RenderWidgetHost's destruction led here, so don't call it.
host_ = NULL;
+ if (GetTextInputManager() && GetTextInputManager()->HasObserver(this))
+ GetTextInputManager()->RemoveObserver(this);
+
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698