Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2354793003: Browser Side TextInputState Tracking for Android (Closed)
Patch Set: Addressing creis@'s comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 0ac77152c1d894993b73fedd962a885adfcb6620..ae198fa20981980a8fc7b2cfd3268a745f17cb0e 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -26,6 +26,7 @@
#include "content/browser/renderer_host/ime_adapter_android.h"
#include "content/browser/renderer_host/input/stylus_text_selector.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
+#include "content/browser/renderer_host/text_input_manager.h"
#include "content/common/content_export.h"
#include "content/public/browser/readback_types.h"
#include "gpu/command_buffer/common/mailbox.h"
@@ -77,7 +78,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
public DelegatedFrameEvictorClient,
public StylusTextSelectorClient,
public ui::TouchSelectionControllerClient,
- public content::ContentViewCoreImplObserver {
+ public content::ContentViewCoreImplObserver,
+ public content::TextInputManager::Observer {
public:
RenderWidgetHostViewAndroid(RenderWidgetHostImpl* widget,
ContentViewCoreImpl* content_view_core);
@@ -111,7 +113,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
float GetBottomControlsHeight() const override;
void UpdateCursor(const WebCursor& cursor) override;
void SetIsLoading(bool is_loading) override;
- void TextInputStateChanged(const TextInputState& params) override;
void ImeCancelComposition() override;
void ImeCompositionRangeChanged(
const gfx::Range& range,
@@ -247,6 +248,11 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
static void OnContextLost();
+ // TextInputManager::Observer overrides.
+ void OnUpdateTextInputStateCalled(TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view,
+ bool did_change_state) override;
+
private:
void RunAckCallbacks();

Powered by Google App Engine
This is Rietveld 408576698