Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2354783005:
Lock down Polymer elements versions (Closed)
DescriptionLock down Polymer elements versions
This means we can more thoroughly audit changes as well as update only
individual elements as needed.
R=dpapad@chromium.org
TBR=michaelpg@chromium.org
BUG=none
NOTRY=true
Committed: https://crrev.com/46561e2a9b902546677a1fe00a0adf380a2188d9
Cr-Commit-Position: refs/heads/master@{#419963}
Patch Set 1 #
Total comments: 2
Dependent Patchsets: Messages
Total messages: 29 (17 generated)
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=michaelpg@chromium.org BUG=none ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=tsergeant@chromium.org BUG=none ==========
dbeam@chromium.org changed reviewers: + tsergeant@chromium.org - michaelpg@chromium.org
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=tsergeant@chromium.org BUG=none ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R= BUG=none ==========
dbeam@chromium.org changed reviewers: - tsergeant@chromium.org
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R= BUG=none ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=tsergeant@chromium.org BUG=none ==========
dbeam@chromium.org changed reviewers: + tsergeant@chromium.org
dpapad@chromium.org changed reviewers: + dpapad@chromium.org
LGTM https://codereview.chromium.org/2354783005/diff/1/third_party/web-animations-... File third_party/web-animations-js/sources/.bower.json (right): https://codereview.chromium.org/2354783005/diff/1/third_party/web-animations-... third_party/web-animations-js/sources/.bower.json:36: "commit": "8cf9e3567c8a30e905e6a2aefb2ebf4120da6859" Is this file necessary?
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=tsergeant@chromium.org BUG=none ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org BUG=none ==========
dbeam@chromium.org changed reviewers: - tsergeant@chromium.org
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org BUG=none ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org BUG=none NOTRY=true ==========
https://codereview.chromium.org/2354783005/diff/1/third_party/web-animations-... File third_party/web-animations-js/sources/.bower.json (right): https://codereview.chromium.org/2354783005/diff/1/third_party/web-animations-... third_party/web-animations-js/sources/.bower.json:36: "commit": "8cf9e3567c8a30e905e6a2aefb2ebf4120da6859" On 2016/09/21 02:30:55, dpapad wrote: > Is this file necessary? i don't think it's /necessary/, but it's helpful for bower to know if it's got the local version cached already (i.e. speeds up `bower install`)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org BUG=none NOTRY=true ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org TBR=michaelpg@chromium.org BUG=none NOTRY=true ==========
TBR=michaelpg@ for web-animations-js
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dbeam@chromium.org changed reviewers: + michaelpg@chromium.org
Message was sent while issue was closed.
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org TBR=michaelpg@chromium.org BUG=none NOTRY=true ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org TBR=michaelpg@chromium.org BUG=none NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org TBR=michaelpg@chromium.org BUG=none NOTRY=true ========== to ========== Lock down Polymer elements versions This means we can more thoroughly audit changes as well as update only individual elements as needed. R=dpapad@chromium.org TBR=michaelpg@chromium.org BUG=none NOTRY=true Committed: https://crrev.com/46561e2a9b902546677a1fe00a0adf380a2188d9 Cr-Commit-Position: refs/heads/master@{#419963} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46561e2a9b902546677a1fe00a0adf380a2188d9 Cr-Commit-Position: refs/heads/master@{#419963}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
