Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: ui/gfx/geometry/size_unittest.cc

Issue 2354783004: Fix overflow/underflow in gfx geometry once and for all (Closed)
Patch Set: Remove accessibility test changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/geometry/size.cc ('k') | ui/gfx/geometry/vector2d.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/geometry/size_unittest.cc
diff --git a/ui/gfx/geometry/size_unittest.cc b/ui/gfx/geometry/size_unittest.cc
index 085fbfb29fd1e225207f9440ece62dc5a4270054..16b1ddceaec9ed6b96e8bebc5c1173627edc7a7e 100644
--- a/ui/gfx/geometry/size_unittest.cc
+++ b/ui/gfx/geometry/size_unittest.cc
@@ -122,4 +122,35 @@ TEST(SizeTest, ClampSizeF) {
EXPECT_EQ(SizeF(3.5f, 5.5f).ToString(), a.ToString());
}
+TEST(SizeTest, Enlarge) {
+ Size test(3, 4);
+ test.Enlarge(5, -8);
+ EXPECT_EQ(test, Size(8, -4));
+}
+
+TEST(SizeTest, IntegerOverflow) {
+ int int_max = std::numeric_limits<int>::max();
+ int int_min = std::numeric_limits<int>::min();
+
+ Size max_size(int_max, int_max);
+ Size min_size(int_min, int_min);
+ Size test;
+
+ test = Size();
+ test.Enlarge(int_max, int_max);
+ EXPECT_EQ(test, max_size);
+
+ test = Size();
+ test.Enlarge(int_min, int_min);
+ EXPECT_EQ(test, min_size);
+
+ test = Size(10, 20);
+ test.Enlarge(int_max, int_max);
+ EXPECT_EQ(test, max_size);
+
+ test = Size(-10, -20);
+ test.Enlarge(int_min, int_min);
+ EXPECT_EQ(test, min_size);
+}
+
} // namespace gfx
« no previous file with comments | « ui/gfx/geometry/size.cc ('k') | ui/gfx/geometry/vector2d.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698