media/capture/video/blob_utils.h - Issue 2354783002: ImageCapture: Implement takePhoto() for Windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/capture/video/blob_utils.h

Issue 2354783002: ImageCapture: Implement takePhoto() for Windows (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_CAPTURE_VIDEO_BLOB_UTILS_H_

	6 #define MEDIA_CAPTURE_VIDEO_BLOB_UTILS_H_

	7

	8 #include "media/mojo/interfaces/image_capture.mojom.h"

	9

	10 namespace media {

	11

	12 struct VideoCaptureFormat;

	13

	14 // Helper method to create a mojom::Blob out of \|buffer\|, whose pixel format and

	15 // resolution are taken from \|capture_format\|. Returns a null BlobPtr in case of

	16 // error.

	17 mojom::BlobPtr Blobify(const uint8_t* buffer,

	18 const uint32_t bytesused,

	19 VideoCaptureFormat capture_format);
	xianglu 2016/09/20 18:43:03 Consider: const VideoCaptureFormat& capture_fo Consider: const VideoCaptureFormat& capture_format Prefer pass-by-reference to pass-by-value, especially when you are going to make a copy of its members inside the function. mcasas 2016/09/20 19:51:10 Good one. Done. Show quoted text On 2016/09/20 18:43:03, xianglu wrote: > Consider: > const VideoCaptureFormat& capture_format > Prefer pass-by-reference to pass-by-value, especially when you are going to make > a copy of its members inside the function. Good one. Done.
	20

	21 } // namespace media

	22

	23 #endif // MEDIA_CAPTURE_VIDEO_BLOB_UTILS_H_

OLD	NEW