Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2354773006: [elements] Handlify raw parameter_map pointers for SloppyArgumentsAccessor (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] Handlify raw parameter_map pointers for SloppyArgumentsAccessor Handlify pointers in IncludesValueImpl and DirectCollectElementIndicesImpl. BUG=chromium:648373 Committed: https://crrev.com/2fd6d6093e746b561e8711897707ef7ce0e14467 Cr-Commit-Position: refs/heads/master@{#39586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M src/elements.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-648373-sloppy-arguments-includesValues.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 3 months ago (2016-09-21 08:34:46 UTC) #2
jgruber
lgtm
4 years, 3 months ago (2016-09-21 09:26:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354773006/1
4 years, 3 months ago (2016-09-21 09:29:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 10:22:27 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 10:23:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fd6d6093e746b561e8711897707ef7ce0e14467
Cr-Commit-Position: refs/heads/master@{#39586}

Powered by Google App Engine
This is Rietveld 408576698