third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp - Issue 2354773003: Make stylesheet owner node a reference instead of pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

Issue 2354773003: Make stylesheet owner node a reference instead of pointer. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/StyleElement.cpp ('K') | « third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

diff --git a/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp b/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

index 1aa7edcbfd206c6d06c079dbf3f1f0787555910b..ae1a8bcdb6e0c1caf1847144d600a8c400329917 100644

--- a/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

+++ b/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp

@@ -44,12 +44,12 @@ TreeScopeStyleSheetCollection::TreeScopeStyleSheetCollection(TreeScope& treeScop

{

}

-void TreeScopeStyleSheetCollection::addStyleSheetCandidateNode(Node* node)

+void TreeScopeStyleSheetCollection::addStyleSheetCandidateNode(Node& node)

{

- if (!node->isConnected())

+ if (!node.isConnected())

return;

- m_styleSheetCandidateNodes.add(node);

+ m_styleSheetCandidateNodes.add(&node);

}

TreeScopeStyleSheetCollection::StyleResolverUpdateType TreeScopeStyleSheetCollection::compareStyleSheets(const HeapVector<Member<CSSStyleSheet>>& oldStyleSheets, const HeapVector<Member<CSSStyleSheet>>& newStylesheets, HeapVector<Member<StyleSheetContents>>& addedSheets)