Make stylesheet owner node a reference instead of pointer.

third_party/WebKit/Source/core/dom/StyleElement.cpp

 /*
  * Copyright (C) 2006, 2007 Rob Buis
  * Copyright (C) 2008 Apple, Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 20 matching lines @@
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "core/html/HTMLStyleElement.h"
 #include "core/svg/SVGStyleElement.h"
 #include "platform/TraceEvent.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace blink {
 
-static bool isCSS(Element* element, const AtomicString& type)
+static bool isCSS(const Element& element, const AtomicString& type)
 {
-    return type.isEmpty() || (element->isHTMLElement() ? equalIgnoringCase(type, "text/css") : (type == "text/css"));
+    return type.isEmpty() || (element.isHTMLElement() ? equalIgnoringCase(type, "text/css") : (type == "text/css"));
 }
 
 StyleElement::StyleElement(Document* document, bool createdByParser)
     : m_createdByParser(createdByParser)
     , m_loading(false)
     , m_registeredAsCandidate(false)
     , m_startPosition(TextPosition::belowRangePosition())
 {
     if (createdByParser && document && document->scriptableDocumentParser() && !document->isInDocumentWrite())
         m_startPosition = document->scriptableDocumentParser()->textPosition();
 }
 
 StyleElement::~StyleElement()
 {
 }
 
-StyleElement::ProcessingResult StyleElement::processStyleSheet(Document& document, Element* element)
+StyleElement::ProcessingResult StyleElement::processStyleSheet(Document& document, Element& element)
 {
     TRACE_EVENT0("blink", "StyleElement::processStyleSheet");
-    DCHECK(element);
-    DCHECK(element->isConnected());
+    DCHECK(element.isConnected());
 
     m_registeredAsCandidate = true;
     document.styleEngine().addStyleSheetCandidateNode(element);
     if (m_createdByParser)
         return ProcessingSuccessful;
 
     return process(element);
 }
 
-void StyleElement::insertedInto(Element* element, ContainerNode* insertionPoint)
+void StyleElement::insertedInto(Element& element, ContainerNode* insertionPoint)

[sashab, 2016/09/21 01:33:29]

insertionPoint could probably be a ContainerNode& too here and below, happy for
you to do this in a separate patch.

[rune, 2016/09/21 07:17:46]

Yes, most likely.

 {
-    if (!insertionPoint->isConnected() || !element->isInShadowTree())
+    if (!insertionPoint->isConnected() || !element.isInShadowTree())
         return;
-    if (ShadowRoot* scope = element->containingShadowRoot())
+    if (ShadowRoot* scope = element.containingShadowRoot())
         scope->registerScopedHTMLStyleChild();
 }
 
-void StyleElement::removedFrom(Element* element, ContainerNode* insertionPoint)
+void StyleElement::removedFrom(Element& element, ContainerNode* insertionPoint)
 {
     if (!insertionPoint->isConnected())
         return;
 
-    ShadowRoot* shadowRoot = element->containingShadowRoot();
+    ShadowRoot* shadowRoot = element.containingShadowRoot();
     if (!shadowRoot)
         shadowRoot = insertionPoint->containingShadowRoot();
 
     if (shadowRoot)
         shadowRoot->unregisterScopedHTMLStyleChild();
 
-    Document& document = element->document();
+    Document& document = element.document();
     if (m_registeredAsCandidate) {
         document.styleEngine().removeStyleSheetCandidateNode(element, shadowRoot ? *toTreeScope(shadowRoot) : toTreeScope(document));
         m_registeredAsCandidate = false;
     }
 
     StyleSheet* removedSheet = m_sheet.get();
 
     if (m_sheet)
         clearSheet(element);
     if (removedSheet)
         document.styleEngine().setNeedsActiveStyleUpdate(removedSheet, AnalyzedStyleUpdate);
 }
 
-StyleElement::ProcessingResult StyleElement::childrenChanged(Element* element)
+StyleElement::ProcessingResult StyleElement::childrenChanged(Element& element)
 {
-    DCHECK(element);
     if (m_createdByParser)
         return ProcessingSuccessful;
 
     return process(element);
 }
 
-StyleElement::ProcessingResult StyleElement::finishParsingChildren(Element* element)
+StyleElement::ProcessingResult StyleElement::finishParsingChildren(Element& element)
 {
-    DCHECK(element);
     ProcessingResult result = process(element);
     m_createdByParser = false;
     return result;
 }
 
-StyleElement::ProcessingResult StyleElement::process(Element* element)
+StyleElement::ProcessingResult StyleElement::process(Element& element)
 {
-    if (!element || !element->isConnected())
+    if (!element.isConnected())
         return ProcessingSuccessful;
-    return createSheet(element, element->textFromChildren());
+    return createSheet(element, element.textFromChildren());
 }
 
-void StyleElement::clearSheet(Element* ownerElement)
+void StyleElement::clearSheet(Element& ownerElement)
 {
     DCHECK(m_sheet);
 
-    if (ownerElement && m_sheet->isLoading())
-        ownerElement->document().styleEngine().removePendingSheet(ownerElement, m_styleEngineContext);
+    if (m_sheet->isLoading())
+        ownerElement.document().styleEngine().removePendingSheet(ownerElement, m_styleEngineContext);
 
     m_sheet.release()->clearOwnerNode();
 }
 
-static bool shouldBypassMainWorldCSP(Element* element)
+static bool shouldBypassMainWorldCSP(const Element& element)
 {
     // Main world CSP is bypassed within an isolated world.
-    LocalFrame* frame = element->document().frame();
+    LocalFrame* frame = element.document().frame();
     if (frame && frame->script().shouldBypassMainWorldCSP())
         return true;
 
     // Main world CSP is bypassed for style elements in user agent shadow DOM.
-    ShadowRoot* root = element->containingShadowRoot();
+    ShadowRoot* root = element.containingShadowRoot();
     if (root && root->type() == ShadowRootType::UserAgent)
         return true;
 
     return false;
 }
 
-StyleElement::ProcessingResult StyleElement::createSheet(Element* e, const String& text)
+StyleElement::ProcessingResult StyleElement::createSheet(Element& element, const String& text)
 {
-    DCHECK(e);
-    DCHECK(e->isConnected());
-    Document& document = e->document();
+    DCHECK(element.isConnected());
+    Document& document = element.document();
 
     const ContentSecurityPolicy* csp = document.contentSecurityPolicy();
-    bool passesContentSecurityPolicyChecks = shouldBypassMainWorldCSP(e)
+    bool passesContentSecurityPolicyChecks = shouldBypassMainWorldCSP(element)
         || csp->allowStyleWithHash(text, ContentSecurityPolicy::InlineType::Block)
-        || csp->allowInlineStyle(e->document().url(), e->fastGetAttribute(HTMLNames::nonceAttr), m_startPosition.m_line, text);
+        || csp->allowInlineStyle(document.url(), element.fastGetAttribute(HTMLNames::nonceAttr), m_startPosition.m_line, text);

[sashab, 2016/09/21 01:33:29]

Nice additional fix with element.document.url()! :)

 
     // Clearing the current sheet may remove the cache entry so create the new sheet first
     CSSStyleSheet* newSheet = nullptr;
 
     // If type is empty or CSS, this is a CSS style sheet.
     const AtomicString& type = this->type();
-    if (isCSS(e, type) && passesContentSecurityPolicyChecks) {
+    if (isCSS(element, type) && passesContentSecurityPolicyChecks) {
         MediaQuerySet* mediaQueries = MediaQuerySet::create(media());
 
         MediaQueryEvaluator screenEval("screen", true);
         MediaQueryEvaluator printEval("print", true);
         if (screenEval.eval(mediaQueries) || printEval.eval(mediaQueries)) {
             m_loading = true;
             TextPosition startPosition = m_startPosition == TextPosition::belowRangePosition() ? TextPosition::minimumPosition() : m_startPosition;
-            newSheet = document.styleEngine().createSheet(e, text, startPosition, m_styleEngineContext);
+            newSheet = document.styleEngine().createSheet(element, text, startPosition, m_styleEngineContext);
             newSheet->setMediaQueries(mediaQueries);
             m_loading = false;
         }
     }
 
     if (m_sheet)
-        clearSheet(e);
+        clearSheet(element);
 
     m_sheet = newSheet;
     if (m_sheet)
         m_sheet->contents()->checkLoaded();
 
     return passesContentSecurityPolicyChecks ? ProcessingSuccessful : ProcessingFatalError;
 }
 
 bool StyleElement::isLoading() const
 {
     if (m_loading)
         return true;
     return m_sheet ? m_sheet->isLoading() : false;
 }
 
 bool StyleElement::sheetLoaded(Document& document)
 {
     if (isLoading())
         return false;
 
-    document.styleEngine().removePendingSheet(m_sheet->ownerNode(), m_styleEngineContext);
+    document.styleEngine().removePendingSheet(*m_sheet->ownerNode(), m_styleEngineContext);
     return true;
 }
 
 void StyleElement::startLoadingDynamicSheet(Document& document)
 {
     document.styleEngine().addPendingSheet(m_styleEngineContext);
 }
 
 DEFINE_TRACE(StyleElement)
 {
     visitor->trace(m_sheet);
 }
 
 } // namespace blink