Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2354773002: Add debugger safe point on assignment to global variables (Closed)

Created:
4 years, 3 months ago by hausner
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add debugger safe point on assignment to global variables Just like we do for local variables, add a debug step check (and thus a breakpoint location) to global variable assignment if the right side of the assignment has no possible breakpoint locations. BUG=#27287 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/0dd760092d808bd387852204f30e4a2ba398b01f

Patch Set 1 #

Patch Set 2 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A runtime/observatory/tests/service/issue_27287_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 3 months ago (2016-09-19 23:27:23 UTC) #3
Cutch
LGTM after adding a regression service protocol test.
4 years, 3 months ago (2016-09-20 18:36:24 UTC) #4
hausner
4 years, 3 months ago (2016-09-20 21:05:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0dd760092d808bd387852204f30e4a2ba398b01f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698