Instantiate PageLoadTrackers for prerenders

Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders (bug 648338),
and addresses bug 648341 where an internal error is logged every time a
prerender sends metrics data from the render process to the browser process.

BUG=648341
Committed: https://crrev.com/e8b60aa78b10f60af6d3f879385f5db1e8ac427a
Cr-Commit-Position: refs/heads/master@{#420398}

[Bryan McQuade, 2016-09-19 19:35:52]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:36:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-19 19:38:31]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:38:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:03:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bryan McQuade, 2016-09-20 12:40:02]

Description was changed from

==========
Prototype change to start tracking prerenders.

BUG=
==========

to

==========
Prototype change to start tracking prerenders.

BUG=648341
==========

[Bryan McQuade, 2016-09-20 12:41:04]

Description was changed from

==========
Prototype change to start tracking prerenders.

BUG=648341
==========

to

==========
Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders, and addresses bug

648341 where an internal error is logged every time a prerender sends metrics
data from the render process to the browser process.

BUG=648341
==========

[Bryan McQuade, 2016-09-20 12:44:38]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 12:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-20 13:11:40]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-20 14:12:21]

Description was changed from

==========
Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders, and addresses bug

648341 where an internal error is logged every time a prerender sends metrics
data from the render process to the browser process.

BUG=648341
==========

to

==========
Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders (bug 648338),
and addresses bug 648341 where an internal error is logged every time a
prerender sends metrics data from the render process to the browser process.

BUG=648341
==========

[Bryan McQuade, 2016-09-20 14:13:46]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-09-20 14:13:55]

PTAL

[commit-bot: I haz the power, 2016-09-20 14:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:22:40]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-09-22 14:51:25]

Thanks

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
(right):

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc:280:
observer_->WasHidden();
Does removing this cause the test to fail?

[Bryan McQuade, 2016-09-22 15:14:37]

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
(right):

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc:280:
observer_->WasHidden();
On 2016/09/22 at 14:51:24, Charlie Harrison wrote:
> Does removing this cause the test to fail?

I added a DCHECK(!started_in_foreground_); for the prerender case, to make sure
that bit gets set sanely for prerenders. As a result, I had to change this as
well.

[Charlie Harrison, 2016-09-22 15:16:31]

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
(right):

https://codereview.chromium.org/2354703002/diff/60001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc:280:
observer_->WasHidden();
On 2016/09/22 15:14:37, Bryan McQuade wrote:
> On 2016/09/22 at 14:51:24, Charlie Harrison wrote:
> > Does removing this cause the test to fail?
> 
> I added a DCHECK(!started_in_foreground_); for the prerender case, to make
sure
> that bit gets set sanely for prerenders. As a result, I had to change this as
> well.

Ahh, right! LGTM that's what I want.

[Bryan McQuade, 2016-09-22 15:16:56]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:17:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 16:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:03:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bryan McQuade, 2016-09-22 17:47:35]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:18:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 18:20:08]

Description was changed from

==========
Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders (bug 648338),
and addresses bug 648341 where an internal error is logged every time a
prerender sends metrics data from the render process to the browser process.

BUG=648341
==========

to

==========
Instantiate PageLoadTrackers for prerenders

This gets us closer to adding support for tracking prerenders (bug 648338),
and addresses bug 648341 where an internal error is logged every time a
prerender sends metrics data from the render process to the browser process.

BUG=648341

Committed: https://crrev.com/e8b60aa78b10f60af6d3f879385f5db1e8ac427a
Cr-Commit-Position: refs/heads/master@{#420398}
==========

[commit-bot: I haz the power, 2016-09-22 18:20:09]

Patchset 4 (id:??) landed as
https://crrev.com/e8b60aa78b10f60af6d3f879385f5db1e8ac427a
Cr-Commit-Position: refs/heads/master@{#420398}