Issue 23547014: Update perf sizes expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23547014: Update perf sizes expectations (Closed)

Created:
7 years, 3 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update perf sizes expectations We switched to Aura on Windows and its bigger, the chrome.dll size. By about 1.6 megs. Not sure what I am doing, the command was python update_perf_expectations.py -f xp-release/sizes/chrome.dll/chrome.dll --reva 223293 --revb 223296 Where 223293 was the revision were it got larger. BUG=none TEST=none TBR=maurel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223310

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/perf_expectations/perf_expectations.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

I don't know this change looks strange. I am doing something wrong I think.

7 years, 3 months ago (2013-09-16 05:17:37 UTC) #1

cpu_(ooo_6.6-7.5)

I think I got it. I needed to run the 'make' one. I'll try it ...

7 years, 3 months ago (2013-09-16 05:21:36 UTC) #2

M-A Ruel

7 years, 3 months ago (2013-09-16 12:34:16 UTC) #4

Message was sent while issue was closed.

On 2013/09/16 05:21:36, cpu wrote:
> I think I got it. I needed to run the 'make' one. I'll try it now.

BTW I know next to nothing to perf expectations. I didn't even know the script
update_perf_expectations.py existed. Back in my days, we used to write json at
hand.

Expand Messages | Collapse Messages