Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issue 2354683003: Fix BigE for Rework scanner-character-streams. (Closed)

Created:
4 years, 3 months ago by john.yan
Modified:
4 years, 3 months ago
Reviewers:
nickie, vogelheim, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix BigE for Rework scanner-character-streams. R=vogelheim@chromium.org BUG= Committed: https://crrev.com/eb57f22e2b106565efb2036e3216442cdf7d89d0 Cr-Commit-Position: refs/heads/master@{#39529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/parsing/scanner-character-streams.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
john.yan
PTAL
4 years, 3 months ago (2016-09-19 20:13:50 UTC) #3
vogelheim
lgtm John, thanks for fixing this!
4 years, 3 months ago (2016-09-20 07:39:26 UTC) #4
marja
lgtm
4 years, 3 months ago (2016-09-20 07:54:43 UTC) #5
marja
(I'll check the commit box on this.)
4 years, 3 months ago (2016-09-20 07:55:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354683003/1
4 years, 3 months ago (2016-09-20 07:55:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 08:25:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 08:26:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb57f22e2b106565efb2036e3216442cdf7d89d0
Cr-Commit-Position: refs/heads/master@{#39529}

Powered by Google App Engine
This is Rietveld 408576698