Add TabStripModel as a parameter of some functions in TabStripModelObserver

Add TabStripModel as a parameter of some functions in TabStripModelObserver

The affected function are TabInsertedAt() and TabPinnedStateChanged().

This change includes no functional changes and it will be used in a
subsequent CL.

Committed: https://crrev.com/9119e490217017b2aed128d012b764e1bf0a9dd4
Cr-Commit-Position: refs/heads/master@{#419872}

[Patrick Monette, 2016-09-19 21:11:23]

The CQ bit was checked by pmonette@chromium.org to run a CQ dry run

[Patrick Monette, 2016-09-19 21:11:33]

pmonette@chromium.org changed reviewers:
+ sky@chromium.org

[Patrick Monette, 2016-09-19 21:11:34]

PTAL.

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/ui/views/ash...
File chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc (left):

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/ui/views/ash...
chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc:201: void
TabInsertedAt(content::WebContents* contents,
Some cleanup while I'm here. Those already have an empty implementation.

[commit-bot: I haz the power, 2016-09-19 21:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:25:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-09-19 22:52:58]

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/devtools/glo...
File chrome/browser/devtools/global_confirm_info_bar.cc (right):

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/devtools/glo...
chrome/browser/devtools/global_confirm_info_bar.cc:166: void
GlobalConfirmInfoBar::TabInsertedAt(TabStripModel* tab_strip_model,
Good comment, but this is still rather rather error prone. How about adding a
function that both this and TabChangedAt call into that doesn't take the
TabStripModel? Alternatively update TabChangedAt to take the TabStripModel too.

[Patrick Monette, 2016-09-20 17:46:27]

The CQ bit was checked by pmonette@chromium.org to run a CQ dry run

[Patrick Monette, 2016-09-20 17:46:54]

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/devtools/glo...
File chrome/browser/devtools/global_confirm_info_bar.cc (right):

https://codereview.chromium.org/2354673004/diff/1/chrome/browser/devtools/glo...
chrome/browser/devtools/global_confirm_info_bar.cc:166: void
GlobalConfirmInfoBar::TabInsertedAt(TabStripModel* tab_strip_model,
On 2016/09/19 22:52:58, sky wrote:
> Good comment, but this is still rather rather error prone. How about adding a
> function that both this and TabChangedAt call into that doesn't take the
> TabStripModel? Alternatively update TabChangedAt to take the TabStripModel
too.

Done. Can you double check that the code in TabChangedAt() was redundant?

[commit-bot: I haz the power, 2016-09-20 17:47:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:43:47]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-20 20:00:46]

LGTM

https://codereview.chromium.org/2354673004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/global_confirm_info_bar.cc (right):

https://codereview.chromium.org/2354673004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/global_confirm_info_bar.cc:198: if
(proxies_.find(infobar_service) != proxies_.end())
optional: ContainsKey(proxies_, infobar_service); (in base/stl_util.h)

[Patrick Monette, 2016-09-20 20:11:54]

https://codereview.chromium.org/2354673004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/global_confirm_info_bar.cc (right):

https://codereview.chromium.org/2354673004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/global_confirm_info_bar.cc:198: if
(proxies_.find(infobar_service) != proxies_.end())
On 2016/09/20 20:00:46, sky wrote:
> optional: ContainsKey(proxies_, infobar_service); (in base/stl_util.h)

Done.

[Patrick Monette, 2016-09-20 20:11:58]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-09-20 20:11:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2354673004/#ps40001
(title: "Last nits")

[commit-bot: I haz the power, 2016-09-20 20:12:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:04:41]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Patrick Monette, 2016-09-20 21:05:42]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:06:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:15:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 22:19:09]

Description was changed from

==========
Add TabStripModel as a parameter of some functions in TabStripModelObserver

The affected function are TabInsertedAt() and TabPinnedStateChanged().

This change includes no functional changes and it will be used in a
subsequent CL.
==========

to

==========
Add TabStripModel as a parameter of some functions in TabStripModelObserver

The affected function are TabInsertedAt() and TabPinnedStateChanged().

This change includes no functional changes and it will be used in a
subsequent CL.

Committed: https://crrev.com/9119e490217017b2aed128d012b764e1bf0a9dd4
Cr-Commit-Position: refs/heads/master@{#419872}
==========

[commit-bot: I haz the power, 2016-09-20 22:19:10]

Patchset 3 (id:??) landed as
https://crrev.com/9119e490217017b2aed128d012b764e1bf0a9dd4
Cr-Commit-Position: refs/heads/master@{#419872}