Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2354653003: Implements BidirectionalStreamQuicImpl::GetLoadTimingInfo (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements BidirectionalStreamQuicImpl::GetLoadTimingInfo This CL adds an implementation of GetLoadTimingInfo in BidirectionalStreamQuicImpl. This is a part of the effort to expose timing metrics to net embedders. BUG=648346 Committed: https://crrev.com/35cf8a18703ec277c344b70eb2f84623693d9179 Cr-Commit-Position: refs/heads/master@{#419939}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -8 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 4 chunks +12 lines, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 13 chunks +135 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
xunjieli
Ryan: PTAL. Thanks!
4 years, 3 months ago (2016-09-20 14:12:44 UTC) #12
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-20 17:22:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354653003/100001
4 years, 3 months ago (2016-09-21 00:36:52 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 3 months ago (2016-09-21 01:56:50 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 01:59:46 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/35cf8a18703ec277c344b70eb2f84623693d9179
Cr-Commit-Position: refs/heads/master@{#419939}

Powered by Google App Engine
This is Rietveld 408576698