Add a cache counter for iOS.

Add a cache counter for iOS.

The CacheCounter class in chrome/browser/browsing_data could not be
componentized (unlike other counters in components/browsing_data) because
of its usage of StoragePartitionHttpCacheDataRemover that has a dependency
on content/.

This CL implements a separate CacheCounter class for iOS with the same
functionality. The core of the implementation, a series of IO thread
callbacks, is delegated to the private IOThreadCacheCounter class that
mimics StoragePartitionHttpCacheDataRemover.

BUG=620317
Committed: https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb
Cr-Commit-Position: refs/heads/master@{#420599}

[msramek, 2016-09-19 17:43:16]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:43:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:02:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-19 18:50:08]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:03:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msramek, 2016-09-19 20:08:15]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:20:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msramek, 2016-09-19 22:23:26]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:23:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:38:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 09:19:08]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 09:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:31:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 12:23:41]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 12:23:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:33:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msramek, 2016-09-20 12:36:14]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 12:36:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:45:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 12:47:33]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 12:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:53:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 14:39:00]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:39:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:41:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 14:54:58]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:55:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:14:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msramek, 2016-09-20 15:17:40]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:18:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-20 15:34:04]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:34:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-20 15:50:15]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:03:43]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 16:04:18]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:37:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-20 16:49:46]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:50:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:47:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-21 11:53:50]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 11:54:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-21 12:44:32]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 12:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 13:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 13:12:48]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-21 13:24:56]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 13:25:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 13:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 13:35:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-21 13:40:02]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 13:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 14:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 14:47:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-22 11:56:44]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 11:57:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-22 12:35:14]

msramek@chromium.org changed reviewers:
+ droger@chromium.org

[msramek, 2016-09-22 12:35:15]

Hey David,

Please have a look! This is a part of Ioana's recent work on iOS browsing_data/,
some of which you have been reviewing.

CacheCounter hasn't been componentized (it stayed in c/b/browsing_data/) because
of a content/ dependency through StoragePartitionHttpCacheDataRemover. We could
break that class to make it componentizable, but it seems simpler to just
introduce an iOS version of CacheCounter, as the functionality is not that
large.

Thanks,
Martin

[msramek, 2016-09-22 12:35:35]

msramek@chromium.org changed reviewers:
+ ioanap@google.com

[msramek, 2016-09-22 12:35:36]

+Ioana PTAL as well :)

[commit-bot: I haz the power, 2016-09-22 12:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 12:45:32]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-09-22 13:39:53]

lgtm

Could you also update browsing_data::GetCounterTextFromResult in
components/browsing_data/core/browsing_data_utils.cc and
GetChromeCounterTextFromResult in
c/b/browsing_data/browsing_data_counter_utils.cc ?

I think the logic that processes the text for the cache counter can now be
completely moved.

Thanks,
Ioana

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter.h (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.h:28: // BrowsingDataCounter
implementation:
nit: s/:/.

[droger, 2016-09-22 14:13:02]

lgtm

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter.cc (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:45: void CountInternal(int rv)
{
Add DCHECK_CURRENTLY_ON(IO);

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:64: break;
Sometimes it's return, sometimes break.

Maybe use return everywhere?

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:90: void OnCountingFinished()
{
DCHECK_CURRENTLY_ON(UI);
Or a base::ThreadChecker if you prefer.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:92:
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
Just curious: why not
delete this;

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter_unittest.cc (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter_unittest.cc:35: void SetUp()
override {
call the parent function
testing::Test::SetUp();

Or better: move this code to the constructor instead (which is the recommended
way).

[msramek, 2016-09-22 14:47:48]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 14:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-22 14:57:12]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 14:57:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-22 15:05:00]

Patchset #22 (id:420001) has been deleted

[commit-bot: I haz the power, 2016-09-22 15:06:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[commit-bot: I haz the power, 2016-09-22 15:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:15:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[msramek, 2016-09-22 16:55:21]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 16:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-22 17:02:40]

Thanks both!

Ioana, as discussed offline, it's not possible to move the CacheCounter text
processing into components/ due to a dependency on ui/base/text files that are
not available on iOS. That logic will have to be duplicated using iOS native UI
libraries.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter.cc (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:45: void CountInternal(int rv)
{
On 2016/09/22 14:13:01, droger wrote:
> Add DCHECK_CURRENTLY_ON(IO);

Done.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:64: break;
On 2016/09/22 14:13:01, droger wrote:
> Sometimes it's return, sometimes break.
> 
> Maybe use return everywhere?

That is intentional. All disk_cache::Backend methods have the same interface -
they either return a value immediately, or they return net::ERR_IO_PENDING and
then later call a callback.

Here, "break;" is used to jump out of the switch(), but not out of while(), so
if |rv| != ERR_IO_PENDING, the next step is executed immediately. Using
"return;" would exit the method and wait for a callback that never comes.

In STEP_CALLBACK, we use "return;", because it's the last step. Using "break;"
would execute that step ad infinitum.

I added a sentinel STEP_DONE to represent the finished state, so that we can use
"break;" here as well.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:90: void OnCountingFinished()
{
On 2016/09/22 14:13:01, droger wrote:
> DCHECK_CURRENTLY_ON(UI);
> Or a base::ThreadChecker if you prefer.

Done.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.cc:92:
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
On 2016/09/22 14:13:01, droger wrote:
> Just curious: why not
> delete this;

Changed to "delete this;". No particular reason - it just feels weird to me that
I cannot assume the object exists after I just called a method on it :)

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter.h (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter.h:28: // BrowsingDataCounter
implementation:
On 2016/09/22 13:39:52, ioanap wrote:
> nit: s/:/.

Done, here and above. This was actually intentional, but I guess a period works
better.

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
File ios/chrome/browser/browsing_data/cache_counter_unittest.cc (right):

https://codereview.chromium.org/2354643002/diff/380001/ios/chrome/browser/bro...
ios/chrome/browser/browsing_data/cache_counter_unittest.cc:35: void SetUp()
override {
On 2016/09/22 14:13:01, droger wrote:
> call the parent function
> testing::Test::SetUp();
> 
> Or better: move this code to the constructor instead (which is the recommended
> way).

Done.

[commit-bot: I haz the power, 2016-09-22 17:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:06:27]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-22 17:38:26]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 17:38:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:09:17]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msramek, 2016-09-22 19:24:02]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[msramek, 2016-09-22 19:24:24]

Patchset #25 (id:500001) has been deleted

[commit-bot: I haz the power, 2016-09-22 19:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:53:58]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-09-23 08:57:37]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-09-23 08:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
ioanap@google.com
Link to the patchset: https://codereview.chromium.org/2354643002/#ps480001
(title: "Forgot |next_step_|")

[commit-bot: I haz the power, 2016-09-23 08:57:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:36:48]

Committed patchset #24 (id:480001)

[commit-bot: I haz the power, 2016-09-23 11:38:19]

Description was changed from

==========
Add a cache counter for iOS.

The CacheCounter class in chrome/browser/browsing_data could not be
componentized (unlike other counters in components/browsing_data) because
of its usage of StoragePartitionHttpCacheDataRemover that has a dependency
on content/.

This CL implements a separate CacheCounter class for iOS with the same
functionality. The core of the implementation, a series of IO thread
callbacks, is delegated to the private IOThreadCacheCounter class that
mimics StoragePartitionHttpCacheDataRemover.

BUG=620317
==========

to

==========
Add a cache counter for iOS.

The CacheCounter class in chrome/browser/browsing_data could not be
componentized (unlike other counters in components/browsing_data) because
of its usage of StoragePartitionHttpCacheDataRemover that has a dependency
on content/.

This CL implements a separate CacheCounter class for iOS with the same
functionality. The core of the implementation, a series of IO thread
callbacks, is delegated to the private IOThreadCacheCounter class that
mimics StoragePartitionHttpCacheDataRemover.

BUG=620317

Committed: https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb
Cr-Commit-Position: refs/heads/master@{#420599}
==========

[commit-bot: I haz the power, 2016-09-23 11:38:21]

Patchset 24 (id:??) landed as
https://crrev.com/2d290dc4a1bcac7ad6cd67553e5831fa3680d6bb
Cr-Commit-Position: refs/heads/master@{#420599}