Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2354623003: Pull boringssl generated source from boringssl_gen (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, abarth
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull boringssl generated source from boringssl_gen Dart and Flutter engine both need to have the code generated for boringssl under //third_party/boringssl. To avoid having two copies of this code, this CL removes it from the Dart repo and instead pulls it from a github repo that Flutter engine can share. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/43231d9ff416e301206239b76ad645ca38f34116

Patch Set 1 #

Patch Set 2 : Remove unused flags #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -197010 lines) Patch
M DEPS View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 2 2 chunks +1 line, -13 lines 0 comments Download
M third_party/.gitignore View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D third_party/boringssl/.gitignore View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/boringssl/BUILD.gn View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/boringssl/BUILD.generated.gni View 1 2 1 chunk +0 lines, -458 lines 0 comments Download
D third_party/boringssl/BUILD.generated_tests.gni View 1 2 1 chunk +0 lines, -584 lines 0 comments Download
D third_party/boringssl/README View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/boringssl/boringssl.gypi View 1 2 1 chunk +0 lines, -443 lines 0 comments Download
D third_party/boringssl/boringssl_configurations.gypi View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/boringssl/boringssl_dart.gyp View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/boringssl/boringssl_tests.gypi View 1 2 1 chunk +0 lines, -671 lines 0 comments Download
D third_party/boringssl/err_data.c View 1 2 1 chunk +0 lines, -1248 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/aes/aesv8-armx64.S View 1 2 1 chunk +0 lines, -757 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/bn/armv8-mont.S View 1 2 1 chunk +0 lines, -1407 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/chacha/chacha-armv8.S View 1 2 1 chunk +0 lines, -1971 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/modes/ghashv8-armx64.S View 1 2 1 chunk +0 lines, -235 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/sha/sha1-armv8.S View 1 2 1 chunk +0 lines, -1216 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/sha/sha256-armv8.S View 1 2 1 chunk +0 lines, -1146 lines 0 comments Download
D third_party/boringssl/linux-aarch64/crypto/sha/sha512-armv8.S View 1 2 1 chunk +0 lines, -1026 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/aes/aes-armv4.S View 1 2 1 chunk +0 lines, -1200 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/aes/aesv8-armx32.S View 1 2 1 chunk +0 lines, -762 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/aes/bsaes-armv7.S View 1 2 1 chunk +0 lines, -2577 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/bn/armv4-mont.S View 1 2 1 chunk +0 lines, -589 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/chacha/chacha-armv4.S View 1 2 1 chunk +0 lines, -1471 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/modes/ghash-armv4.S View 1 2 1 chunk +0 lines, -538 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/modes/ghashv8-armx32.S View 1 2 1 chunk +0 lines, -236 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/sha/sha1-armv4-large.S View 1 2 1 chunk +0 lines, -1463 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/sha/sha256-armv4.S View 1 2 1 chunk +0 lines, -2820 lines 0 comments Download
D third_party/boringssl/linux-arm/crypto/sha/sha512-armv4.S View 1 2 1 chunk +0 lines, -1871 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/aes/aes-586.S View 1 2 1 chunk +0 lines, -3257 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/aes/aesni-x86.S View 1 2 1 chunk +0 lines, -2469 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/aes/vpaes-x86.S View 1 2 1 chunk +0 lines, -676 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/bn/bn-586.S View 1 2 1 chunk +0 lines, -1538 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/bn/co-586.S View 1 2 1 chunk +0 lines, -1260 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/bn/x86-mont.S View 1 2 1 chunk +0 lines, -460 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/chacha/chacha-x86.S View 1 2 1 chunk +0 lines, -969 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/md5/md5-586.S View 1 2 1 chunk +0 lines, -682 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/modes/ghash-x86.S View 1 2 1 chunk +0 lines, -1274 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/rc4/rc4-586.S View 1 2 1 chunk +0 lines, -350 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/sha/sha1-586.S View 1 2 1 chunk +0 lines, -3802 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/sha/sha256-586.S View 1 2 1 chunk +0 lines, -5561 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/sha/sha512-586.S View 1 2 1 chunk +0 lines, -2831 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/aes/aes-x86_64.S View 1 2 1 chunk +0 lines, -2536 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/aes/aesni-x86_64.S View 1 2 1 chunk +0 lines, -3565 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/aes/bsaes-x86_64.S View 1 2 1 chunk +0 lines, -2507 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/aes/vpaes-x86_64.S View 1 2 1 chunk +0 lines, -834 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/bn/rsaz-avx2.S View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/bn/rsaz-x86_64.S View 1 2 1 chunk +0 lines, -1229 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/bn/x86_64-mont.S View 1 2 1 chunk +0 lines, -750 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/bn/x86_64-mont5.S View 1 2 1 chunk +0 lines, -2241 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/chacha/chacha-x86_64.S View 1 2 1 chunk +0 lines, -1585 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/ec/p256-x86_64-asm.S View 1 2 1 chunk +0 lines, -1789 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/md5/md5-x86_64.S View 1 2 1 chunk +0 lines, -671 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/modes/aesni-gcm-x86_64.S View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/modes/ghash-x86_64.S View 1 2 1 chunk +0 lines, -1329 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/rand/rdrand-x86_64.S View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/rc4/rc4-x86_64.S View 1 2 1 chunk +0 lines, -596 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/sha/sha1-x86_64.S View 1 2 1 chunk +0 lines, -3547 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/sha/sha256-x86_64.S View 1 2 1 chunk +0 lines, -3906 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/sha/sha512-x86_64.S View 1 2 1 chunk +0 lines, -4028 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/aes/aes-586.S View 1 2 1 chunk +0 lines, -3221 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/aes/aesni-x86.S View 1 2 1 chunk +0 lines, -2433 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/aes/vpaes-x86.S View 1 2 1 chunk +0 lines, -650 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/bn/bn-586.S View 1 2 1 chunk +0 lines, -1528 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/bn/co-586.S View 1 2 1 chunk +0 lines, -1252 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/bn/x86-mont.S View 1 2 1 chunk +0 lines, -462 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/chacha/chacha-x86.S View 1 2 1 chunk +0 lines, -969 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/md5/md5-586.S View 1 2 1 chunk +0 lines, -680 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/modes/ghash-x86.S View 1 2 1 chunk +0 lines, -1260 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/rc4/rc4-586.S View 1 2 1 chunk +0 lines, -350 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/sha/sha1-586.S View 1 2 1 chunk +0 lines, -3800 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/sha/sha256-586.S View 1 2 1 chunk +0 lines, -5563 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/sha/sha512-586.S View 1 2 1 chunk +0 lines, -2833 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/aes/aes-x86_64.S View 1 2 1 chunk +0 lines, -2535 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/aes/aesni-x86_64.S View 1 2 1 chunk +0 lines, -3564 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/aes/bsaes-x86_64.S View 1 2 1 chunk +0 lines, -2504 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/aes/vpaes-x86_64.S View 1 2 1 chunk +0 lines, -834 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/bn/rsaz-avx2.S View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/bn/rsaz-x86_64.S View 1 2 1 chunk +0 lines, -1228 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/bn/x86_64-mont.S View 1 2 1 chunk +0 lines, -748 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/bn/x86_64-mont5.S View 1 2 1 chunk +0 lines, -2240 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/chacha/chacha-x86_64.S View 1 2 1 chunk +0 lines, -1584 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/ec/p256-x86_64-asm.S View 1 2 1 chunk +0 lines, -1788 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/md5/md5-x86_64.S View 1 2 1 chunk +0 lines, -671 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/modes/aesni-gcm-x86_64.S View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/modes/ghash-x86_64.S View 1 2 1 chunk +0 lines, -1328 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/rand/rdrand-x86_64.S View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/rc4/rc4-x86_64.S View 1 2 1 chunk +0 lines, -595 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/sha/sha1-x86_64.S View 1 2 1 chunk +0 lines, -3546 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/sha/sha256-x86_64.S View 1 2 1 chunk +0 lines, -3905 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/sha/sha512-x86_64.S View 1 2 1 chunk +0 lines, -4027 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/aes/aes-586.asm View 1 2 1 chunk +0 lines, -3219 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/aes/aesni-x86.asm View 1 2 1 chunk +0 lines, -2424 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/aes/vpaes-x86.asm View 1 2 1 chunk +0 lines, -649 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/bn/bn-586.asm View 1 2 1 chunk +0 lines, -1523 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/bn/co-586.asm View 1 2 1 chunk +0 lines, -1260 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/bn/x86-mont.asm View 1 2 1 chunk +0 lines, -469 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/chacha/chacha-x86.asm View 1 2 1 chunk +0 lines, -977 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/md5/md5-586.asm View 1 2 1 chunk +0 lines, -691 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/modes/ghash-x86.asm View 1 2 1 chunk +0 lines, -1265 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/rc4/rc4-586.asm View 1 2 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/sha/sha1-586.asm View 1 2 1 chunk +0 lines, -3808 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/sha/sha256-586.asm View 1 2 1 chunk +0 lines, -5573 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/sha/sha512-586.asm View 1 2 1 chunk +0 lines, -2843 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/aes/aes-x86_64.asm View 1 2 1 chunk +0 lines, -2858 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/aes/aesni-x86_64.asm View 1 2 1 chunk +0 lines, -4027 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/aes/bsaes-x86_64.asm View 1 2 1 chunk +0 lines, -2733 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/aes/vpaes-x86_64.asm View 1 2 1 chunk +0 lines, -1137 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/bn/rsaz-avx2.asm View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/bn/rsaz-x86_64.asm View 1 2 1 chunk +0 lines, -1495 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont.asm View 1 2 1 chunk +0 lines, -963 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont5.asm View 1 2 1 chunk +0 lines, -2444 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/chacha/chacha-x86_64.asm View 1 2 1 chunk +0 lines, -1689 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/ec/p256-x86_64-asm.asm View 1 2 1 chunk +0 lines, -1925 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/md5/md5-x86_64.asm View 1 2 1 chunk +0 lines, -776 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/modes/aesni-gcm-x86_64.asm View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/modes/ghash-x86_64.asm View 1 2 1 chunk +0 lines, -1507 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/rand/rdrand-x86_64.asm View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm View 1 2 1 chunk +0 lines, -741 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/sha/sha1-x86_64.asm View 1 2 1 chunk +0 lines, -3768 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/sha/sha256-x86_64.asm View 1 2 1 chunk +0 lines, -4082 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/sha/sha512-x86_64.asm View 1 2 1 chunk +0 lines, -4212 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 3 months ago (2016-09-20 02:51:55 UTC) #2
zra
4 years, 3 months ago (2016-09-20 14:31:31 UTC) #4
Cutch
lgtm
4 years, 3 months ago (2016-09-20 15:42:17 UTC) #5
zra
4 years, 3 months ago (2016-09-20 15:46:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
43231d9ff416e301206239b76ad645ca38f34116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698