Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: components/browser_sync/abstract_profile_sync_service_test.h

Issue 2354613002: [Sync] Fix namespaces for the browser_sync component. (Closed)
Patch Set: Self-review. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/abstract_profile_sync_service_test.h
diff --git a/components/browser_sync/abstract_profile_sync_service_test.h b/components/browser_sync/abstract_profile_sync_service_test.h
index 439305888961f2e5279c9d353112629034a90e2e..fb3a832e91b0560a6bafea58086fd07bb0430e3b 100644
--- a/components/browser_sync/abstract_profile_sync_service_test.h
+++ b/components/browser_sync/abstract_profile_sync_service_test.h
@@ -19,12 +19,14 @@
#include "components/sync/core/change_record.h"
#include "testing/gtest/include/gtest/gtest.h"
-class TestProfileSyncService;
-
namespace syncer {
struct UserShare;
} // namespace syncer
+namespace browser_sync {
+
skym 2016/09/22 17:25:59 Is it right to have a newline here?
maxbogue 2016/09/22 19:41:15 I think having it makes it clearer that the namesp
+class TestProfileSyncService;
+
class ProfileSyncServiceTestHelper {
public:
static syncer::ImmutableChangeRecordList MakeSingletonChangeRecordList(
@@ -51,7 +53,7 @@ class AbstractProfileSyncServiceTest : public testing::Test {
protected:
// Creates a TestProfileSyncService instance based on
// |profile_sync_service_bundle_|, with start behavior
- // browser_sync::AUTO_START. Passes |callback| down to
+ // AUTO_START. Passes |callback| down to
skym 2016/09/22 17:25:59 Why'd you strip off the namespace here?
maxbogue 2016/09/22 19:41:15 I literally did s/browser_sync::// in this directo
// SyncManagerForProfileSyncTest to be used by NotifyInitializationSuccess.
// |sync_client| is passed to the service. The created service is stored in
// |sync_service_|.
@@ -67,7 +69,7 @@ class AbstractProfileSyncServiceTest : public testing::Test {
// inheritance of its template arguments.
base::Callback<sync_driver::SyncService*(void)> GetSyncServiceCallback();
- browser_sync::ProfileSyncServiceBundle* profile_sync_service_bundle() {
+ ProfileSyncServiceBundle* profile_sync_service_bundle() {
return &profile_sync_service_bundle_;
}
@@ -76,7 +78,7 @@ class AbstractProfileSyncServiceTest : public testing::Test {
base::Thread data_type_thread_;
base::TestMessageLoop message_loop_;
- browser_sync::ProfileSyncServiceBundle profile_sync_service_bundle_;
+ ProfileSyncServiceBundle profile_sync_service_bundle_;
std::unique_ptr<TestProfileSyncService> sync_service_;
base::ScopedTempDir temp_dir_; // To pass to the backend host.
@@ -104,4 +106,6 @@ class CreateRootHelper {
DISALLOW_COPY_AND_ASSIGN(CreateRootHelper);
};
+} // namespace browser_sync
+
#endif // COMPONENTS_BROWSER_SYNC_ABSTRACT_PROFILE_SYNC_SERVICE_TEST_H_

Powered by Google App Engine
This is Rietveld 408576698