[Sync] Fix namespaces for the browser_sync component.

chrome/browser/ui/sync/one_click_signin_sync_starter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
 
 #include <stddef.h>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 26 matching lines @@
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/sync/driver/sync_prefs.h"
 #include "content/public/browser/user_metrics.h"
 #include "net/base/url_util.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/l10n/l10n_util.h"
 
+using browser_sync::ProfileSyncService;

[skym, 2016/09/22 17:25:58]

I can't seem to figure out why you sometimes go with using, and sometimes not. I
suppose it doesn't really matter.

[maxbogue, 2016/09/22 19:41:14]

General rule of thumb was if the file had > ~5 uses, or used subclasses like
PSS::SyncStatusSummary, ::InitParams, etc. I don't think I was super consistent
though.

+
 namespace {
 
 // UMA histogram for tracking what users do when presented with the signin
 // screen.
 // Hence,
 //   (a) existing enumerated constants should never be deleted or reordered, and
 //   (b) new constants should only be appended at the end of the enumeration.
 //
 // Keep this in sync with SigninChoice in histograms.xml.
 enum SigninChoice {
@@ skipping 583 matching lines @@
                                             false /* user_gesture */);
 }
 
 void OneClickSigninSyncStarter::LoadContinueUrl() {
   web_contents()->GetController().LoadURL(
       continue_url_,
       content::Referrer(),
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
       std::string());
 }