Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there…

Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/bad7f763749587c704070a7f4e62cf61ebedd781

[Jacob, 2016-09-19 21:00:13]

jacobr@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[Jacob, 2016-09-19 21:00:14]

Is there a better fix? I need this change to avoid compiler crashes when asserts
fire that something__<bottom>
is not a valid identifier name.
I'm guessing something changed in the analyzer resulting in "<bottom>" being
sometimes returned as a type name. Would also be reasonable to clean it up so
that the name the analyzer uses is identifier friendly. E.g. $bottom$. If the
name is being used in error messages as well, that fix would be suboptimal.

[Jennifer Messerly, 2016-09-19 21:17:51]

lgtm w/ suggested fix

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/type_utilities.dart (right):

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:77: // TODO(jacobr): are
there more unsafe names we need to check for?
should be good. We handle everything else later on, as long as it's at least a
valid Dart identifier. It just wasn't expecting invalid characters :)

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:78: if (name ==
'<bottom>') return r'$$bottom$$';
you can just use "bottom" or "BottomType" here. We have a renamer that will take
care of conflicts, so no worries about the dollar signs :)

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:109: if (type is
TypeParameterType) return _safeTypeName(type.name);
type parameter types won't be named "<bottom>" so no need to change this one.

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:110: if (type.name !=
null) return _safeTypeName(type.name);
incidentally this final bit could be refactored:

return _safeTypeName(type.name ?? "type");

[Jacob, 2016-09-19 21:49:32]

applied all suggested fixes

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/type_utilities.dart (right):

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:109: if (type is
TypeParameterType) return _safeTypeName(type.name);
On 2016/09/19 21:17:51, John Messerly wrote:
> type parameter types won't be named "<bottom>" so no need to change this one.

Done.

https://codereview.chromium.org/2354603003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/type_utilities.dart:110: if (type.name !=
null) return _safeTypeName(type.name);
On 2016/09/19 21:17:51, John Messerly wrote:
> incidentally this final bit could be refactored:
> 
> return _safeTypeName(type.name ?? "type");

Done.

[Jacob, 2016-09-19 21:52:17]

Description was changed from

==========
Fix crashes due to attempts to create an identifier name containing the word
<bottom>. Likely there is a better fix but this appears to work for now.

BUG=
==========

to

==========
Fix crashes due to attempts to create an identifier name containing the word
<bottom>. Likely there is a better fix but this appears to work for now.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/bad7f763749587c704070a7f4e62...
==========

[Jacob, 2016-09-19 21:52:19]

Committed patchset #2 (id:20001) manually as
bad7f763749587c704070a7f4e62cf61ebedd781 (presubmit successful).