Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9847)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

Issue 23546007: [rAC, OSX] Namespaced constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix namespace comment. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
index 12606a27d40b743d0ad9833b5ed893174195de7a..95b7584cb1aaf40ab94959b5e1caec4b9342dc4e 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
@@ -41,12 +41,13 @@
NSBezierPath* arrow = [NSBezierPath bezierPath];
[arrow moveToPoint:anchorPoint];
- [arrow relativeLineToPoint:NSMakePoint(-kArrowWidth / 2.0, -kArrowHeight)];
- [arrow relativeLineToPoint:NSMakePoint(kArrowWidth, 0)];
+ [arrow relativeLineToPoint:
+ NSMakePoint(-autofill::kArrowWidth / 2.0, -autofill::kArrowHeight)];
+ [arrow relativeLineToPoint:NSMakePoint(autofill::kArrowWidth, 0)];
[arrow closePath];
[backgroundColor_ setFill];
[arrow fill];
- backgroundRect.size.height -= kArrowHeight;
+ backgroundRect.size.height -= autofill::kArrowHeight;
}
dirtyRect = NSIntersectionRect(backgroundRect, dirtyRect);
@@ -149,9 +150,9 @@
}
if ([[self notificationView] hasArrow])
- preferredSize.height += kArrowHeight;
+ preferredSize.height += autofill::kArrowHeight;
- preferredSize.height += 2 * kNotificationPadding;
+ preferredSize.height += 2 * autofill::kNotificationPadding;
return preferredSize;
}
@@ -163,9 +164,9 @@
- (void)performLayout {
NSRect bounds = [[self view] bounds];
if ([[self notificationView] hasArrow])
- bounds.size.height -= kArrowHeight;
+ bounds.size.height -= autofill::kArrowHeight;
- NSRect textFrame = NSInsetRect(bounds, 0, kNotificationPadding);
+ NSRect textFrame = NSInsetRect(bounds, 0, autofill::kNotificationPadding);
if (![checkbox_ isHidden]) {
// Temporarily resize checkbox to just the box, no extra clickable area.
textFrame.origin.x += checkboxSizeWithoutTitle_.width;

Powered by Google App Engine
This is Rietveld 408576698