Fix test for warn_unused_result and move it to v8config.h.

src/globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 339 matching lines @@
 #endif
 #elif defined(_MSC_VER) && !defined(DEBUG)
 #define INLINE(header) __forceinline header
 #define NO_INLINE(header) header
 #else
 #define INLINE(header) inline header
 #define NO_INLINE(header) header
 #endif
 
 
-#if defined(__GNUC__) && __GNUC__ >= 4
-#define MUST_USE_RESULT __attribute__ ((warn_unused_result))
-#else
-#define MUST_USE_RESULT
-#endif
+// Newly written code should use V8_WARN_UNUSED_RESULT.

[Michael Starzinger, 2013/08/27 08:23:43]

Thanks for not touching another 528 occurrences of "MUST_USE_RESULT" throughout
the codebase!

+#define MUST_USE_RESULT V8_WARN_UNUSED_RESULT
 
 
 // Define DISABLE_ASAN macros.
 #if defined(__has_feature)
 #if __has_feature(address_sanitizer)
 #define DISABLE_ASAN __attribute__((no_address_safety_analysis))
 #endif
 #endif
 
 
@@ skipping 50 matching lines @@
 // the backend, so both modes are represented by the kStrictMode value.
 enum StrictModeFlag {
   kNonStrictMode,
   kStrictMode
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_GLOBALS_H_