Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2354583004: clang bots: Use gcc 4.8.5 instead of 4.8.2 as stage1 compiler. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang bots: Use gcc 4.8.5 instead of 4.8.2 as stage1 compiler. For reasons not fully understood, some of clang's tests started failing when building clang with gcc 4.8.2 but they pass with 4.8.4 or 4.8.5. Since we do bootstrap builds when building clang binaries, the stage1 host compiler doesn't matter much to us, so just flip the bots to gcc 4.8.5 and move on with life. I built 4.8.5 (in a precise vm) with: contrib/download_prerequisites mkdir build && cd build ../configure --prefix=$HOME/gcc485precise --enable-languages=c,c++ --enable-checking=release time make -j10 make install-strip tar czf gcc485precise.tgz gcc485precise cd ~ ~/gsutil/gsutil cp -n -a public-read gcc485precise.tgz gs://chromium-browser-clang/tools/gcc485precise.tgz i.e. I switched from `make install` to `make install-strip`, which also reduces download size from 125MB to 30 MB. BUG=648300 TBR=hans Committed: https://chromium.googlesource.com/chromium/src/+/6e96f3f9582481230cee3a6e8987cc877940fab6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
4 years, 3 months ago (2016-09-20 00:01:01 UTC) #5
Nico
ima tbr this so that the bots can cycle while i commute home and i ...
4 years, 3 months ago (2016-09-20 00:08:15 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e96f3f9582481230cee3a6e8987cc877940fab6 Cr-Commit-Position: refs/heads/master@{#419607}
4 years, 3 months ago (2016-09-20 00:13:48 UTC) #10
Nico
Committed patchset #1 (id:1) manually as 6e96f3f9582481230cee3a6e8987cc877940fab6 (presubmit successful).
4 years, 3 months ago (2016-09-20 00:14:52 UTC) #12
hans
4 years, 3 months ago (2016-09-20 04:01:10 UTC) #13
Message was sent while issue was closed.
lgtm

> i.e. I switched from `make install` to `make install-strip`, which also
reduces
download size from 125MB to 30 MB.

Nice :-)

Powered by Google App Engine
This is Rietveld 408576698