src/pdf/SkPDFFont.cpp - Issue 2354583002: SkPDF: SkBitSet gets reset() to make drop() better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFFont.cpp

Issue 2354583002: SkPDF: SkBitSet gets reset() to make drop() better. (Closed)

Patch Set: call destructor directly Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFFont.cpp

diff --git a/src/pdf/SkPDFFont.cpp b/src/pdf/SkPDFFont.cpp

index 89c7951f6356b0671afec5b102f67b4521ba500d..682f721c265b67e782fb1345d53b432dcc7af458 100644

--- a/src/pdf/SkPDFFont.cpp

+++ b/src/pdf/SkPDFFont.cpp

@@ -727,5 +727,7 @@ bool SkPDFFont::CanEmbedTypeface(SkTypeface* typeface, SkPDFCanon* canon) {

void SkPDFFont::drop() {

fTypeface = nullptr;

+ fGlyphUsage.~SkBitSet();

+ new (&fGlyphUsage) SkBitSet(0);

this->SkPDFDict::drop();

}

« no previous file with comments | « no previous file | src/utils/SkBitSet.h » ('j') | no next file with comments »