Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2354563002: Fix for CrossProcessMouseEnterAndLeaveTest on high DPI machines (Closed)

Created:
4 years, 3 months ago by kenrb
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for CrossProcessMouseEnterAndLeaveTest on high DPI machines Using hard-coded coordinates for mouse input events resolves the problem of GetViewBounds returning CSS pixels, which are inconsistent across different device scale factors. BUG=647202 Committed: https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e Cr-Commit-Position: refs/heads/master@{#419474}

Patch Set 1 #

Patch Set 2 : Fix for CrossProcessMouseEnterAndLeaveTest on high DPI machines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
kenrb
avi: PTAL? (very small CL)
4 years, 3 months ago (2016-09-19 16:00:54 UTC) #10
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-19 16:05:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354563002/20001
4 years, 3 months ago (2016-09-19 16:08:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 16:13:33 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 16:15:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e
Cr-Commit-Position: refs/heads/master@{#419474}

Powered by Google App Engine
This is Rietveld 408576698