Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235453008: DevTools: Extract CPU profile model out of CPUProfileView. (Closed)

Created:
6 years, 8 months ago by alph
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Extract CPU profile model out of CPUProfileView. CPUFlameChartDataProvider is made to not depend on CPUProfileView. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -113 lines) Patch
M LayoutTests/inspector/profiler/cpu-profiler-calculate-time.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/cpu-profiler-save-load.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/profiler/profiler-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 11 chunks +110 lines, -106 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alph
ptal
6 years, 8 months ago (2014-04-13 09:12:14 UTC) #1
yurys
lgtm
6 years, 8 months ago (2014-04-14 07:36:06 UTC) #2
alph
The CQ bit was checked by alph@chromium.org
6 years, 8 months ago (2014-04-14 07:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/235453008/1
6 years, 8 months ago (2014-04-14 07:40:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 08:11:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-14 08:11:37 UTC) #6
alph
The CQ bit was checked by alph@chromium.org
6 years, 8 months ago (2014-04-14 08:21:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/235453008/1
6 years, 8 months ago (2014-04-14 08:21:26 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 09:02:46 UTC) #9
Message was sent while issue was closed. 
Change committed as 171445

Powered by Google App Engine
This is Rietveld 408576698