Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 235453004: Reland 171036i "Hook up gin platform to blink, and explicitly manage the main ..." (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
blink-reviews
Visibility:
Public.

Description

Reland 171036i "Hook up gin platform to blink, and explicitly manage the main ..." > We'll soon get rid of the v8 default isolate, so we'll need to manage > our own. > > To test the platform implementation, run with > --js-flags="--noparallel_sweeping --concurrent-sweeping --job-based-sweeping" > > BUG=359977 > R=dcarney@chromium.org,haraken@chromium.org > > Original review https://codereview.chromium.org/227653002/ BUG=359977 TBR=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebKit.cpp View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-11 19:54:01 UTC) #1
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-11 19:54:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/235453004/1
6 years, 8 months ago (2014-04-11 19:54:22 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 20:55:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-11 20:55:22 UTC) #5
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-11 21:01:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/235453004/1
6 years, 8 months ago (2014-04-11 21:01:12 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 22:09:34 UTC) #8
Message was sent while issue was closed.
Change committed as 171374

Powered by Google App Engine
This is Rietveld 408576698