Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 23545029: EME: Handle NO_KEY and resume playback after key is added. (Closed)

Created:
7 years, 3 months ago by xhwang
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

EME: Handle NO_KEY and resume playback after key is added. - Now we can notify demuxer ready as soon as the demuxer is ready. We don't need to wait for a key to be added if the stream is encrypted. - QueueSeureInputBuffer() et al return MediaCodecStatus to pass detailed status. - If no key is available the media pipeline pauses. - After a key is added we try to resume the media pipeline playback. BUG=277211, 255781, 281663 TEST=Start decoding without key is added and see no crash. After key is added playback resumes. R=acolwell@chromium.org, jschuh@chromium.org, qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221331

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -113 lines) Patch
M content/browser/android/browser_media_player_manager.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 6 chunks +13 lines, -6 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 4 chunks +6 lines, -2 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 8 chunks +84 lines, -17 lines 0 comments Download
M media/base/android/media_codec_bridge.h View 3 chunks +12 lines, -14 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 5 chunks +22 lines, -41 lines 0 comments Download
M media/base/android/media_decoder_job.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 6 chunks +38 lines, -17 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_player_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/android/media_source_player.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 7 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
xhwang
qinmin, acolwell: PTAL! jschuh: Please OWNER review content/common/media/media_player_messages_android.h.
7 years, 3 months ago (2013-09-04 20:22:32 UTC) #1
qinmin
lgtm
7 years, 3 months ago (2013-09-04 20:39:11 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
7 years, 3 months ago (2013-09-04 20:45:46 UTC) #3
jschuh
ipc security lgtm. appears to just be removing gtv attack surface from normal android.
7 years, 3 months ago (2013-09-04 22:17:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/23545029/1
7 years, 3 months ago (2013-09-04 22:44:09 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 23:11:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/23545029/1
7 years, 3 months ago (2013-09-04 23:19:39 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 23:27:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/23545029/24001
7 years, 3 months ago (2013-09-05 01:10:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82919
7 years, 3 months ago (2013-09-05 02:16:44 UTC) #10
xhwang
7 years, 3 months ago (2013-09-05 02:21:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r221331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698