tools/telemetry/telemetry/page/csv_page_measurement_results.py - Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results.py

Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Forgot to update the unitttests :( Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py ('K') | « tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py ('k') | tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/csv_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results.py b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

index 3770021051e6b091b13c3df328c0df5323c08521..87d8f91f8db907378ef39a67800bc200c8ee7e8c 100644

--- a/tools/telemetry/telemetry/page/csv_page_measurement_results.py

+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

@@ -70,7 +70,7 @@ PageMeasurement.results_are_the_same_on_every_page to return False.

self._did_output_header = True

self._header_names_written_to_writer = list(all_measurement_names)

- row = ['url']

+ row = ['page_name']

for measurement_name in all_measurement_names:

measurement_data = \

self.all_measurements_that_have_been_seen[measurement_name]

@@ -78,7 +78,7 @@ PageMeasurement.results_are_the_same_on_every_page to return False.

self._results_writer.writerow(row)

def _OutputValuesForPage(self, page_values):

- row = [page_values.page.display_url]

+ row = [page_values.page.display_name]

for measurement_name in self._header_names_written_to_writer:

value = page_values.FindValueByMeasurementName(measurement_name)

if value: