tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py - Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Forgot to update the unitttests :( Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/block_page_measurement_results.py ('k') | tools/telemetry/telemetry/page/buildbot_page_measurement_results.py » ('j') | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

index 21af60eaf5d760ab0b05d6b509e8f93439b133f2..a0355fc9d0806ff23a5a3d7990b5bca488709e33 100644

--- a/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

@@ -53,10 +53,10 @@ class BlockPageMeasurementResultsTest(unittest.TestCase):

results.DidMeasurePage()

expected = [

- ['url', 'http://www.foo.com/'],

+ ['name', 'http://www.foo.com/'],

['foo (seconds)', '3'],

[''],

- ['url', 'http://www.bar.com/'],

+ ['name', 'http://www.bar.com/'],

['bar (seconds)', '4'],

['']

]