Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to update the unitttests :( Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/loading_profile.py ('k') | tools/perf/metrics/v8_object_stats.py » ('j') | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/skpicture_printer.py
diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py
index 5a74453e399fc3e0c10faf8fa6717d09d33b17ba..00ded8a83718062b2cb47d5864971aa602b49693 100644
--- a/tools/perf/measurements/skpicture_printer.py
+++ b/tools/perf/measurements/skpicture_printer.py
@@ -26,7 +26,7 @@ class SkpicturePrinter(page_measurement.PageMeasurement):
raise Exception('Please specify --skp-outdir')
outpath = os.path.abspath(
os.path.join(skp_outdir,
- page.url_as_file_safe_name))
+ page.file_safe_name))
# Replace win32 path separator char '\' with '\\'.
js = _JS.format(outpath.replace('\\', '\\\\'))
tab.EvaluateJavaScript(js)
« no previous file with comments | « tools/perf/measurements/loading_profile.py ('k') | tools/perf/metrics/v8_object_stats.py » ('j') | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698