[Activity log] Rework extraction of URLs from argument lists

chrome/browser/extensions/activity_log/activity_log_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "chrome/browser/extensions/activity_log/activity_log.h"
@@ skipping 85 matching lines @@
     ASSERT_EQ("[\"script\"]",
               ActivityLogPolicy::Util::Serialize(last->args()));
     ASSERT_EQ("http://www.google.com/", last->SerializePageUrl());
     ASSERT_EQ("{\"prerender\":true}",
               ActivityLogPolicy::Util::Serialize(last->other()));
     ASSERT_EQ("", last->api_name());
     ASSERT_EQ("", last->page_title());
     ASSERT_EQ("", last->SerializeArgUrl());
   }
 
+  static void RetrieveActions_ArgUrlExtraction(
+      scoped_ptr<std::vector<scoped_refptr<Action> > > i) {
+    ASSERT_EQ(2U, i->size());
+    scoped_refptr<Action> action = i->at(0);
+    ASSERT_EQ("[\"GET\",\"\\u003Carg_url\\u003E\"]",
+              ActivityLogPolicy::Util::Serialize(action->args()));
+    ASSERT_EQ("http://www.google.com/", action->arg_url().spec());
+
+    action = i->at(1);
+    ASSERT_EQ("[{\"url\":\"\\u003Carg_url\\u003E\"}]",
+              ActivityLogPolicy::Util::Serialize(action->args()));
+    ASSERT_EQ("http://www.google.co.uk/", action->arg_url().spec());
+  }
+
   ExtensionService* extension_service_;
 
 #if defined OS_CHROMEOS
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
 #endif
 };
 
 TEST_F(ActivityLogTest, Construct) {
@@ skipping 60 matching lines @@
 
   static_cast<TabHelper::ScriptExecutionObserver*>(activity_log)->
       OnScriptsExecuted(contents, executing_scripts, 0, url);
 
   activity_log->GetActions(
       extension->id(), 0, base::Bind(ActivityLogTest::Arguments_Prerender));
 
   prerender_manager->CancelAllPrerenders();
 }
 
+TEST_F(ActivityLogTest, ArgUrlExtraction) {
+  ActivityLog* activity_log = ActivityLog::GetInstance(profile());
+  scoped_ptr<base::ListValue> args(new base::ListValue());
+
+  base::Time now = base::Time::Now();
+
+  // Submit a DOM API call which should have its URL extracted into the arg_url
+  // field.
+  scoped_refptr<Action> action = new Action(kExtensionId,
+                                            now,
+                                            Action::ACTION_DOM_ACCESS,
+                                            "XMLHttpRequest.open");
+  action->mutable_args()->AppendString("GET");
+  action->mutable_args()->AppendString("http://www.google.com/");
+  activity_log->LogAction(action);
+
+  // Submit an API call with an embedded URL.
+  action = new Action(kExtensionId,
+                      now - base::TimeDelta::FromSeconds(1),
+                      Action::ACTION_API_CALL,
+                      "windows.create");
+  action->set_args(
+      ListBuilder()
+          .Append(DictionaryBuilder().Set("url", "http://www.google.co.uk"))
+          .Build());
+  activity_log->LogAction(action);
+
+  activity_log->GetActions(
+      kExtensionId,
+      0,
+      base::Bind(ActivityLogTest::RetrieveActions_ArgUrlExtraction));
+}
+
 }  // namespace extensions