Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: skia/BUILD.gn

Issue 2354453002: Added "-Wno-signed-enum-bitfield" flag to not trigger Clang warning (Closed)
Patch Set: Moved changes to chrome/src Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//printing/features/features.gni") 7 import("//printing/features/features.gni")
8 import("//testing/test.gni") 8 import("//testing/test.gni")
9 import("//third_party/skia/gn/shared_sources.gni") 9 import("//third_party/skia/gn/shared_sources.gni")
10 10
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 sources += [ 474 sources += [
475 "//third_party/skia/src/ports/SkFontHost_mac.cpp", 475 "//third_party/skia/src/ports/SkFontHost_mac.cpp",
476 "//third_party/skia/src/utils/mac/SkCreateCGImageRef.cpp", 476 "//third_party/skia/src/utils/mac/SkCreateCGImageRef.cpp",
477 "//third_party/skia/src/utils/mac/SkStream_mac.cpp", 477 "//third_party/skia/src/utils/mac/SkStream_mac.cpp",
478 ] 478 ]
479 set_sources_assignment_filter(sources_assignment_filter) 479 set_sources_assignment_filter(sources_assignment_filter)
480 480
481 # SkFontHost_mac.cpp uses API deprecated in iOS 7, crbug.com/408571 481 # SkFontHost_mac.cpp uses API deprecated in iOS 7, crbug.com/408571
482 cflags = [ "-Wno-deprecated-declarations" ] 482 cflags = [ "-Wno-deprecated-declarations" ]
483 } 483 }
484
485 if (is_clang) {
486 # Skia won't build with the enum bitfield warning in Clang, crbug.com/648462
487 cflags += [ "-Wno-signed-enum-bitfield" ]
488 }
484 } 489 }
485 490
486 # Separated out so it can be compiled with different flags for SSE. 491 # Separated out so it can be compiled with different flags for SSE.
487 if (!skia_build_no_opts) { 492 if (!skia_build_no_opts) {
488 if (current_cpu == "arm64") { 493 if (current_cpu == "arm64") {
489 source_set("skia_opts_crc32") { 494 source_set("skia_opts_crc32") {
490 sources = skia_opts.crc32_sources 495 sources = skia_opts.crc32_sources
491 cflags = [ "-march=armv8-a+crc" ] 496 cflags = [ "-march=armv8-a+crc" ]
492 visibility = [ ":skia_opts" ] 497 visibility = [ ":skia_opts" ]
493 configs -= [ "//build/config/compiler:chromium_code" ] 498 configs -= [ "//build/config/compiler:chromium_code" ]
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 730
726 deps = [ 731 deps = [
727 ":skia", 732 ":skia",
728 "//base", 733 "//base",
729 "//base/test:test_support", 734 "//base/test:test_support",
730 "//build/config/sanitizers:deps", 735 "//build/config/sanitizers:deps",
731 "//build/win:default_exe_manifest", 736 "//build/win:default_exe_manifest",
732 ] 737 ]
733 } 738 }
734 } 739 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698