Implement support for Mac Zoom following focus and caret

Implement support for Mac Zoom following focus and caret

BUG=649114
Committed: https://crrev.com/d61b8fc5cbee2a69b77cdeb5dbf8a4abd2d91525
Cr-Commit-Position: refs/heads/master@{#420457}

[dmazzoni, 2016-09-22 07:38:09]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 07:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 07:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:46:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmazzoni, 2016-09-22 17:39:28]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 17:40:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-09-22 17:43:10]

dmazzoni@chromium.org changed reviewers:
+ asvitkine@chromium.org, ekaramad@chromium.org

[dmazzoni, 2016-09-22 17:43:11]

ekaramad: could you review the changes to text_input_manager?

asvitkine: could you review the changes to render_widget_host_view_mac.mm
  and the other minor refactoring?

[commit-bot: I haz the power, 2016-09-22 18:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:35:55]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2016-09-22 19:32:41]

TextInputManager change LGTM. It is great to see such good usage for those
previously unused variables kept in SelectionRegion. Thanks!

[Alexei Svitkine (slow), 2016-09-22 19:45:20]

lgtm

https://codereview.chromium.org/2354413003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2354413003/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:1366: // If the Mac
Zoom featuer is enabled, update it with the bounds of the
featuer -> feature

[dmazzoni, 2016-09-22 20:17:00]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-09-22 20:17:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
ekaramad@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2354413003/#ps40001
(title: "Fix typo")

[dmazzoni, 2016-09-22 20:17:57]

On 2016/09/22 at 19:32:41, ekaramad wrote:
> TextInputManager change LGTM. It is great to see such good usage for those
previously unused variables kept in SelectionRegion. Thanks!

I'm glad they were there, it made my life easier!

[dmazzoni, 2016-09-22 20:18:05]

https://codereview.chromium.org/2354413003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2354413003/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:1366: // If the Mac
Zoom featuer is enabled, update it with the bounds of the
On 2016/09/22 at 19:45:20, Alexei Svitkine (very slow) wrote:
> featuer -> feature

Fixed, thanks

[commit-bot: I haz the power, 2016-09-22 20:18:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:06:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 21:09:00]

Description was changed from

==========
Implement support for Mac Zoom following focus and caret

BUG=649114
==========

to

==========
Implement support for Mac Zoom following focus and caret

BUG=649114

Committed: https://crrev.com/d61b8fc5cbee2a69b77cdeb5dbf8a4abd2d91525
Cr-Commit-Position: refs/heads/master@{#420457}
==========

[commit-bot: I haz the power, 2016-09-22 21:09:02]

Patchset 3 (id:??) landed as
https://crrev.com/d61b8fc5cbee2a69b77cdeb5dbf8a4abd2d91525
Cr-Commit-Position: refs/heads/master@{#420457}