Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2354413002: Rename App to Env where needed. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename App to Env where needed. More instances of CPDFSDK_Environment being called m_pApp in the code. Renamed to m_pEnv to be clear that it's the environment not an app object. Committed: https://pdfium.googlesource.com/pdfium/+/8e0638b1531493e2d5fe3a603f4be60418c78bc4

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_annothandlermgr.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_widgethandler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_xfawidgethandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 15 chunks +23 lines, -23 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/global.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-21 21:00:17 UTC) #4
npm
lg but you probably need to rebase
4 years, 3 months ago (2016-09-21 21:10:51 UTC) #7
dsinclair
Rebased. PTAL.
4 years, 3 months ago (2016-09-22 17:41:56 UTC) #10
npm
lgtm
4 years, 3 months ago (2016-09-22 17:55:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354413002/20001
4 years, 3 months ago (2016-09-22 18:05:45 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:06:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8e0638b1531493e2d5fe3a603f4be60418c7...

Powered by Google App Engine
This is Rietveld 408576698