Implement UI web contents for Vr Shell

Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here: 

BUG=641413
Committed: https://crrev.com/1c89a934e6bbf60077ecebe421f485c5fc10895a
Cr-Commit-Position: refs/heads/master@{#420753}

[mthiesse, 2016-09-21 19:56:14]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org, dfalcantara@chromium.org

[mthiesse, 2016-09-21 19:56:15]

dfalcantara@chromium.org: Please review changes in chrome/android/

bshe@chromium.org: Please review changes in chrome/browser/android/vr_shell/

[mthiesse, 2016-09-21 19:57:27]

On 2016/09/21 19:56:15, mthiesse wrote:
> mailto:dfalcantara@chromium.org: Please review changes in chrome/android/
> 
> mailto:bshe@chromium.org: Please review changes in
chrome/browser/android/vr_shell/

I see that you're OOO tomorrow dfalcantara, should I add somebody else?

[mthiesse, 2016-09-21 20:00:23]

Description was changed from

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=
==========

to

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413
==========

[gone, 2016-09-21 20:07:57]

On 2016/09/21 19:57:27, mthiesse wrote:
> On 2016/09/21 19:56:15, mthiesse wrote:
> > mailto:dfalcantara@chromium.org: Please review changes in chrome/android/
> > 
> > mailto:bshe@chromium.org: Please review changes in
> chrome/browser/android/vr_shell/
> 
> I see that you're OOO tomorrow dfalcantara, should I add somebody else?

Not a bad idea.

[mthiesse, 2016-09-21 20:09:45]

mthiesse@chromium.org changed reviewers:
+ tedchoc@chromium.org

[mthiesse, 2016-09-21 20:09:45]

+tedchoc, please review chrome/android/ changes.

[bshe, 2016-09-21 21:37:35]

vr_shell lgtm with nits

https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
(right):

https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java:83:
private VrWindowAndroid mUiWindowAndroid;
nit: to be consistent, rename to mUiVrWindowAndroid

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (left):

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:84:
->GetRenderWidgetHost()->WasResized();
why is this no longer needed?

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:109: content::NavigationController&
controller = contents->GetController();
nit: controller = ui_cvc_->GetWebContents()->GetController();

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:110: GURL
url(base::StringPiece("chrome://vr-shell-ui"));
nit: similar to this pattern:
https://cs.chromium.org/chromium/src/ui/keyboard/content/keyboard_constants.c...
Add a vr-shell-ui const and use that const.

[mthiesse, 2016-09-21 23:56:48]

https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
(right):

https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java:83:
private VrWindowAndroid mUiWindowAndroid;
On 2016/09/21 21:37:34, bshe wrote:
> nit: to be consistent, rename to mUiVrWindowAndroid

Done.

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (left):

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:84:
->GetRenderWidgetHost()->WasResized();
On 2016/09/21 21:37:34, bshe wrote:
> why is this no longer needed?

It was never needed. I missed removing it when pulling code from our
experimental branch.

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:109: content::NavigationController&
controller = contents->GetController();
On 2016/09/21 21:37:34, bshe wrote:
> nit: controller = ui_cvc_->GetWebContents()->GetController();

Done.

https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:110: GURL
url(base::StringPiece("chrome://vr-shell-ui"));
On 2016/09/21 21:37:34, bshe wrote:
> nit: similar to this pattern:
>
https://cs.chromium.org/chromium/src/ui/keyboard/content/keyboard_constants.c...
> Add a vr-shell-ui const and use that const.

Done.

[mthiesse, 2016-09-23 19:17:40]

On 2016/09/21 23:56:48, mthiesse wrote:
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
> File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
> (right):
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/android/java/src...
> chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java:83:
> private VrWindowAndroid mUiWindowAndroid;
> On 2016/09/21 21:37:34, bshe wrote:
> > nit: to be consistent, rename to mUiVrWindowAndroid
> 
> Done.
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/vr_shell.cc (left):
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/vr_shell.cc:84:
> ->GetRenderWidgetHost()->WasResized();
> On 2016/09/21 21:37:34, bshe wrote:
> > why is this no longer needed?
> 
> It was never needed. I missed removing it when pulling code from our
> experimental branch.
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/vr_shell.cc (right):
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/vr_shell.cc:109:
content::NavigationController&
> controller = contents->GetController();
> On 2016/09/21 21:37:34, bshe wrote:
> > nit: controller = ui_cvc_->GetWebContents()->GetController();
> 
> Done.
> 
>
https://codereview.chromium.org/2354373002/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/vr_shell.cc:110: GURL
> url(base::StringPiece("chrome://vr-shell-ui"));
> On 2016/09/21 21:37:34, bshe wrote:
> > nit: similar to this pattern:
> >
>
https://cs.chromium.org/chromium/src/ui/keyboard/content/keyboard_constants.c...
> > Add a vr-shell-ui const and use that const.
> 
> Done.

ping tedchoc,

This work is blocking many of our other efforts, so I'd like to keep this
moving; let me know if you have any question/concerns I can address.

[Ted C, 2016-09-23 19:40:02]

lgtm

https://codereview.chromium.org/2354373002/diff/40001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.h (right):

https://codereview.chromium.org/2354373002/diff/40001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.h:122: 
one too many blank lines

[mthiesse, 2016-09-23 20:31:06]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2016-09-23 20:31:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org,
tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2354373002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-23 20:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:44:07]

Description was changed from

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413
==========

to

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413
==========

[commit-bot: I haz the power, 2016-09-23 22:44:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-23 22:50:44]

Description was changed from

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413
==========

to

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413

Committed: https://crrev.com/1c89a934e6bbf60077ecebe421f485c5fc10895a
Cr-Commit-Position: refs/heads/master@{#420753}
==========

[commit-bot: I haz the power, 2016-09-23 22:50:45]

Patchset 4 (id:??) landed as
https://crrev.com/1c89a934e6bbf60077ecebe421f485c5fc10895a
Cr-Commit-Position: refs/heads/master@{#420753}

[mthiesse, 2017-03-15 15:31:11]

Description was changed from

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...

BUG=641413

Committed: https://crrev.com/1c89a934e6bbf60077ecebe421f485c5fc10895a
Cr-Commit-Position: refs/heads/master@{#420753}
==========

to

==========
Implement UI web contents for Vr Shell

Design doc describing our UI architecture is here: 

BUG=641413

Committed: https://crrev.com/1c89a934e6bbf60077ecebe421f485c5fc10895a
Cr-Commit-Position: refs/heads/master@{#420753}
==========