Add unit tests for AddToHomescreenDataFetcher

Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support in	content/test/BUILD.gn)

Committed: https://crrev.com/4207dcd418e427ebd7d344d305a8d19414dd0279
Cr-Commit-Position: refs/heads/master@{#421387}

[pkotwicz, 2016-09-23 14:12:28]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-09-23 14:12:29]

Dominick, can you please take a look? Ideally these would be browser tests but
Android does not yet support browser tests. (http://crbug.com/611756)

[pkotwicz, 2016-09-23 14:14:53]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-09-23 14:15:21]

Description was changed from

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
==========

to

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
==========

[dominickn, 2016-09-26 07:36:07]

This looks pretty good, but what's the motivation for moving this to a unit
test? Looks like there's a bit more mocking that's involved to make it a unit
test?

If it should be a browser test on Android, then I kind of feel like it's better
to keep it as an instrumentation test until browser_test support arrives on
Android unless there's a good reason.

https://codereview.chromium.org/2354363007/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
(right):

https://codereview.chromium.org/2354363007/diff/20001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc:64:
bool is_favicon,
Nit: indentation

[pkotwicz, 2016-09-26 18:01:59]

I wrote this CL as a prerequisite for
https://codereview.chromium.org/2362813003/

The unit test makes it possible to test whether the
AddToHomescreenDataFetcher::Observer methods are called when
AddToHomescreenManager::is_webapk_compatible_ is true

[dominickn, 2016-09-27 01:50:32]

On 2016/09/26 18:01:59, pkotwicz wrote:
> I wrote this CL as a prerequisite for
> https://codereview.chromium.org/2362813003/
> 
> The unit test makes it possible to test whether the
> AddToHomescreenDataFetcher::Observer methods are called when
> AddToHomescreenManager::is_webapk_compatible_ is true

Thanks. lgtm.

[pkotwicz, 2016-09-27 15:25:29]

pkotwicz@chromium.org changed reviewers:
+ michaeln@chromium.org

[pkotwicz, 2016-09-27 15:25:30]

pkotwicz@chromium.org changed reviewers:
+ michaeln@chromium.org

[pkotwicz, 2016-09-27 15:25:30]

michaeln@ for new dependency on content/browser/service_worker by
add_to_homescreen_data_fetcher_unittest.cc

[pkotwicz, 2016-09-27 15:25:30]

michaeln@ for new dependency on content/browser/service_worker by
add_to_homescreen_data_fetcher_unittest.cc

[michaeln, 2016-09-27 20:52:07]

r/s lgtm

[pkotwicz, 2016-09-27 22:03:38]

Description was changed from

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
==========

to

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support)
==========

[pkotwicz, 2016-09-27 22:03:43]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-09-27 22:03:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2354363007/#ps60001
(title: "Merge branch 'master' into remove_unneeded_var2.9")

[pkotwicz, 2016-09-27 22:03:51]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2016-09-27 22:04:06]

Description was changed from

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support)
==========

to

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support
in	content/test/BUILD.gn)
==========

[pkotwicz, 2016-09-27 22:04:13]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:46:43]

Description was changed from

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support
in	content/test/BUILD.gn)
==========

to

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support
in	content/test/BUILD.gn)
==========

[commit-bot: I haz the power, 2016-09-27 23:46:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-27 23:48:44]

Description was changed from

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support
in	content/test/BUILD.gn)
==========

to

==========
Add unit tests for AddToHomescreenDataFetcher

This CL makes some of the instrumentation tests in AddToHomescreenManagerTest
unit tests for AddToHomescreenDataFetcher instead

BUG=None
R=dominickn, michaeln
TBR=sky (For moving a file from content_browsertests to test_support
in	content/test/BUILD.gn)

Committed: https://crrev.com/4207dcd418e427ebd7d344d305a8d19414dd0279
Cr-Commit-Position: refs/heads/master@{#421387}
==========

[commit-bot: I haz the power, 2016-09-27 23:48:45]

Patchset 3 (id:??) landed as
https://crrev.com/4207dcd418e427ebd7d344d305a8d19414dd0279
Cr-Commit-Position: refs/heads/master@{#421387}

[tsergeant, 2016-09-29 00:34:49]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2378973002/ by tsergeant@chromium.org.

The reason for reverting is: The new
AddToHomescreenDataFetcherTestCommon.ManifestFetchTimesOut test is flaky on
android_n5x_swarming_rel.

See crbug.com/651047 for further details..