WebRTC: Add android_junit_tests.

scripts/slave/recipe_modules/webrtc/api.py

Index: scripts/slave/recipe_modules/webrtc/api.py
diff --git a/scripts/slave/recipe_modules/webrtc/api.py b/scripts/slave/recipe_modules/webrtc/api.py
index b953f07e58ea870cdbd562cea7c527fbcf56b543..d767eeb9c1dbf56c8f9cd650acd12f2f7e6ea561 100644
--- a/scripts/slave/recipe_modules/webrtc/api.py
+++ b/scripts/slave/recipe_modules/webrtc/api.py
@@ -40,8 +40,7 @@ class WebRTCApi(recipe_api.RecipeApi):
     'xmllite_xmpp_unittests',
   )
 
-  # Android APK tests.
-  ANDROID_APK_TESTS = (
+  ANDROID_DEVICE_TESTS = (
     'audio_decoder_unittests',
     'common_audio_unittests',
     'common_video_unittests',
@@ -58,6 +57,10 @@ class WebRTCApi(recipe_api.RecipeApi):
     'webrtc_nonparallel_tests',
   )
 
+  ANDROID_LINUX_TESTS = (
+    'android_junit_tests',
+  )
+
   ANDROID_INSTRUMENTATION_TESTS = (
     'AppRTCDemoTest',
     'libjingle_peerconnection_android_unittest',
@@ -128,15 +131,18 @@ class WebRTCApi(recipe_api.RecipeApi):
     self.c.enable_swarming = self.bot_config.get('enable_swarming')
     if self.c.use_isolate:
       self.m.isolate.set_isolate_environment(self.m.chromium.c)
+      self._isolated_targets = tuple()
       if self.c.TEST_SUITE == 'webrtc':
-        self._isolated_targets = self.NORMAL_TESTS
-      elif self.c.TEST_SUITE == 'android':
-        self._isolated_targets = (self.ANDROID_APK_TESTS +
+        self._isolated_targets += self.NORMAL_TESTS
+      if self.c.TEST_SUITE in ('android_linux', 'android_swarming'):
+        self._isolated_targets += self.ANDROID_LINUX_TESTS
+      if self.c.TEST_SUITE in ('android_device', 'android_swarming'):
+        self._isolated_targets += (self.ANDROID_DEVICE_TESTS +
             self.ANDROID_INSTRUMENTATION_TESTS)
-      else: # pragma: no cover
+      if not self._isolated_targets: # pragma: no cover
         raise self.m.step.StepFailure('Isolation and swarming are only '
-                                      'supported for webrtc and android test '
-                                      'suites.')
+                                      'supported for webrtc, android_linux and '
+                                      'android_device test suites.')
 
     self.c.enable_swarming = self.bot_config.get('enable_swarming')
     if self.c.enable_swarming:
@@ -204,6 +210,7 @@ class WebRTCApi(recipe_api.RecipeApi):
       with self.m.step.defer_results():
         if tests:
           if (self.m.chromium.c.TARGET_PLATFORM == 'android' and
+              self.c.TEST_SUITE != 'android_linux' and

[kjellander_chromium, 2016/09/27 05:22:29]

Hmm, I don't like this duplication.

Can you introduce a boolean variable so these three criteria are checked only
once? Like:
run_android_device_steps = (self.m.chromium.c.TARGET_PLATFORM == 'android' and
self.c.TEST_SUITE != 'android_linux' and not self.c.enable_swarming)

Then you check that boolean at line 212 and 220.

               not self.c.enable_swarming):
             self.m.chromium_android.common_tests_setup_steps()
 
@@ -211,6 +218,7 @@ class WebRTCApi(recipe_api.RecipeApi):
             test.run(self, suffix='')
 
           if (self.m.chromium.c.TARGET_PLATFORM == 'android' and
+              self.c.TEST_SUITE != 'android_linux' and
               not self.c.enable_swarming):
             self.m.chromium_android.shutdown_device_monitor()
             self.m.chromium_android.logcat_dump(