Move CPDFSDK_Environment code to cpp file

Move CPDFSDK_Environment code to cpp file

This CL moves the code from the .h file into the .cpp file.

Committed: https://pdfium.googlesource.com/pdfium/+/577ad2c9ea89c721ee1dbb89d1f7e12bb8c333f7

[dsinclair, 2016-09-21 20:46:26]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-21 20:47:03]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-21 20:47:03]

PTAL.

This is just copy/paste, no code changes outside the CPDFSDK_Environment::'s.

[Tom Sepez, 2016-09-21 21:05:01]

LGTM.  Thanks.  I noticed this before, and it was bugging me!

[npm, 2016-09-21 21:05:07]

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
File fpdfsdk/cpdfsdk_environment.cpp (right):

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:300: void
CPDFSDK_Environment::OnSetFieldInputFocus(void* field,
Where is field parameter being used? Otherwise, can we just delete it?

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:317: if (m_pInfo && m_pInfo->FFI_DoGoToAction)
Nit: brackets

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:329: if (m_pInfo && m_pInfo->FFI_DisplayCaret)
Ditto

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:370: FX_BOOL bAppend) {
bAppend unused?

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:398: const CFX_PointF* pRectExclude) {
Unused pRectExclude?

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:399: if (m_pInfo && m_pInfo->FFI_PopupMenu)
{}s

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:409: if (m_pInfo && m_pInfo->m_pJsPlatform &&
m_pInfo->m_pJsPlatform->app_alert)
{}s

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:462: FPDF_WIDESTRING URL =
(FPDF_WIDESTRING)bsURL.GetBuffer(bsURL.GetLength());
Remove C-cast

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:465: FPDF_WIDESTRING data =
(FPDF_WIDESTRING)bsData.GetBuffer(bsData.GetLength());
ditto here and several others in this same method

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:485: (unsigned short*)response.str, response.len
/ sizeof(unsigned short));
C-Cast

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:498: FPDF_WIDESTRING URL =
(FPDF_WIDESTRING)bsURL.GetBuffer(bsURL.GetLength());
ditto here and below

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:527: (unsigned
short*)bsRet.GetBuffer(bsRet.GetLength()),
ditto

[commit-bot: I haz the power, 2016-09-21 21:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:05:31]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-22 13:16:46]

PTAL, a bunch of cleanup in here, a quick re-review would be nice.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
File fpdfsdk/cpdfsdk_environment.cpp (right):

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:300: void
CPDFSDK_Environment::OnSetFieldInputFocus(void* field,
On 2016/09/21 21:05:06, npm wrote:
> Where is field parameter being used? Otherwise, can we just delete it?

Done. It looks like the stranger issue is that while we'd pass the field getting
or losing focus into here, the public api would drop the field, which is really
weird.

Removing it from here, we can bring back later if it's needed.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:317: if (m_pInfo && m_pInfo->FFI_DoGoToAction)
On 2016/09/21 21:05:07, npm wrote:
> Nit: brackets

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:329: if (m_pInfo && m_pInfo->FFI_DisplayCaret)
On 2016/09/21 21:05:06, npm wrote:
> Ditto

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:370: FX_BOOL bAppend) {
On 2016/09/21 21:05:06, npm wrote:
> bAppend unused?

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:398: const CFX_PointF* pRectExclude) {
On 2016/09/21 21:05:06, npm wrote:
> Unused pRectExclude?

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:399: if (m_pInfo && m_pInfo->FFI_PopupMenu)
On 2016/09/21 21:05:06, npm wrote:
> {}s

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:409: if (m_pInfo && m_pInfo->m_pJsPlatform &&
m_pInfo->m_pJsPlatform->app_alert)
On 2016/09/21 21:05:06, npm wrote:
> {}s

Done.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:462: FPDF_WIDESTRING URL =
(FPDF_WIDESTRING)bsURL.GetBuffer(bsURL.GetLength());
On 2016/09/21 21:05:07, npm wrote:
> Remove C-cast

FPDF_WIDESTRING is strange and has to be c-style at the moment.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:465: FPDF_WIDESTRING data =
(FPDF_WIDESTRING)bsData.GetBuffer(bsData.GetLength());
On 2016/09/21 21:05:06, npm wrote:
> ditto here and several others in this same method

as above

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:485: (unsigned short*)response.str, response.len
/ sizeof(unsigned short));
On 2016/09/21 21:05:06, npm wrote:
> C-Cast

This is really a FPDF_WIDESTRING.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:498: FPDF_WIDESTRING URL =
(FPDF_WIDESTRING)bsURL.GetBuffer(bsURL.GetLength());
On 2016/09/21 21:05:06, npm wrote:
> ditto here and below

Acknowledged.

https://codereview.chromium.org/2354363003/diff/1/fpdfsdk/cpdfsdk_environment...
fpdfsdk/cpdfsdk_environment.cpp:527: (unsigned
short*)bsRet.GetBuffer(bsRet.GetLength()),
On 2016/09/21 21:05:06, npm wrote:
> ditto

Acknowledged.

[dsinclair, 2016-09-22 13:16:47]

PTAL, a bunch of cleanup in here, a quick re-review would be nice.

[dsinclair, 2016-09-22 13:16:55]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 13:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 13:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 13:28:48]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-22 17:18:23]

lgtm

https://codereview.chromium.org/2354363003/diff/20001/fpdfsdk/cpdfsdk_environ...
File fpdfsdk/cpdfsdk_environment.cpp (right):

https://codereview.chromium.org/2354363003/diff/20001/fpdfsdk/cpdfsdk_environ...
fpdfsdk/cpdfsdk_environment.cpp:210: CFFL_InteractiveFormFiller*
CPDFSDK_Environment::GetInteractiveFormFiller() {
This is from rebase?

[dsinclair, 2016-09-22 17:20:16]

https://codereview.chromium.org/2354363003/diff/20001/fpdfsdk/cpdfsdk_environ...
File fpdfsdk/cpdfsdk_environment.cpp (right):

https://codereview.chromium.org/2354363003/diff/20001/fpdfsdk/cpdfsdk_environ...
fpdfsdk/cpdfsdk_environment.cpp:210: CFFL_InteractiveFormFiller*
CPDFSDK_Environment::GetInteractiveFormFiller() {
On 2016/09/22 17:18:22, npm wrote:
> This is from rebase?

Acknowledged.

[dsinclair, 2016-09-22 17:20:21]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-22 17:20:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2354363003/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-09-22 17:20:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:20:51]

Description was changed from

==========
Move CPDFSDK_Environment code to cpp file

This CL moves the code from the .h file into the .cpp file.
==========

to

==========
Move CPDFSDK_Environment code to cpp file

This CL moves the code from the .h file into the .cpp file.

Committed:
https://pdfium.googlesource.com/pdfium/+/577ad2c9ea89c721ee1dbb89d1f7e12bb8c3...
==========

[commit-bot: I haz the power, 2016-09-22 17:20:52]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/577ad2c9ea89c721ee1dbb89d1f7e12bb8c3...