Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2354343002: CrOS Window cycle ui - set widget bounds with initparams to avoid extra resizing. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

CrOS Window cycle ui - set widget bounds with initparams to avoid extra resizing. This also requires changing Widget::SetInitialBoundsForFramelessWindows, which inexplicably constrains the bounds to a rectangle that is smaller than the work area. BUG=646418 Review-Url: https://codereview.chromium.org/2337213002 Cr-Commit-Position: refs/heads/master@{#418446} (cherry picked from commit 846a59b93f9911517c7aeb05b47af9b4c0cad175) Committed: https://chromium.googlesource.com/chromium/src/+/9fa3cf6e6625f3ebdb8623262e0866f1d39e213f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ash/common/wm/window_cycle_list.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 3 months ago (2016-09-21 17:21:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fa3cf6e6625f3ebdb8623262e0866f1d39e213f.

Powered by Google App Engine
This is Rietveld 408576698