Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 2354333006: Merged: [turbofan] Fix loop assignment analysis on ForInStatements. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647887.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parsing/parser.h" 7 #include "src/parsing/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 VisitIfNotNull(loop->init()); 247 VisitIfNotNull(loop->init());
248 Enter(loop); 248 Enter(loop);
249 VisitIfNotNull(loop->cond()); 249 VisitIfNotNull(loop->cond());
250 Visit(loop->body()); 250 Visit(loop->body());
251 VisitIfNotNull(loop->next()); 251 VisitIfNotNull(loop->next());
252 Exit(loop); 252 Exit(loop);
253 } 253 }
254 254
255 255
256 void ALAA::VisitForInStatement(ForInStatement* loop) { 256 void ALAA::VisitForInStatement(ForInStatement* loop) {
257 Expression* l = loop->each();
257 Enter(loop); 258 Enter(loop);
258 Visit(loop->each()); 259 Visit(l);
259 Visit(loop->subject()); 260 Visit(loop->subject());
260 Visit(loop->body()); 261 Visit(loop->body());
262 if (l->IsVariableProxy()) AnalyzeAssignment(l->AsVariableProxy()->var());
261 Exit(loop); 263 Exit(loop);
262 } 264 }
263 265
264 266
265 void ALAA::VisitForOfStatement(ForOfStatement* loop) { 267 void ALAA::VisitForOfStatement(ForOfStatement* loop) {
266 Visit(loop->assign_iterator()); 268 Visit(loop->assign_iterator());
267 Enter(loop); 269 Enter(loop);
268 Visit(loop->next_result()); 270 Visit(loop->next_result());
269 Visit(loop->result_done()); 271 Visit(loop->result_done());
270 Visit(loop->assign_each()); 272 Visit(loop->assign_each());
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 int count = 0; 315 int count = 0;
314 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 316 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
315 for (size_t i = 0; i < list_.size(); i++) { 317 for (size_t i = 0; i < list_.size(); i++) {
316 if (list_[i].second->Contains(var_index)) count++; 318 if (list_[i].second->Contains(var_index)) count++;
317 } 319 }
318 return count; 320 return count;
319 } 321 }
320 } // namespace compiler 322 } // namespace compiler
321 } // namespace internal 323 } // namespace internal
322 } // namespace v8 324 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-647887.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698